search

MLTSHP / mltshp

Source for the application that runs mltshp.com
https://mltshp.com/
Mozilla Public License 2.0
50 stars 21 forks source link

API won't allow saving to multiple shakes #594

Open spaceninja opened 4 years ago

spaceninja commented 4 years ago

When you save a file for the first time using the API, it will correctly save the file to the shake you specify (or the user shake if not specified), and it will set the saved flag to true.

If you try to save the same file to a different shake, the API will return a 200 as if everything was successful, but what's actually happening is it does nothing because it sees the saved flag is already true and returns early.

Expected behavior: User should be allowed to save a file to multiple shakes.

spaceninja commented 1 year ago

To be fair, this does match the behavior of the share button on MLTSHP.com, but on the main site you can save the same image to additional shakes by visiting the detail page, where there's a checkbox list in the sidebar of all the shakes you can add it to. We should expose this functionality through the API, and the save endpoint is the logical place to do so.