search

MLTSHP / mltshp

Source for the application that runs mltshp.com
https://mltshp.com/
Mozilla Public License 2.0
50 stars 21 forks source link

Heading elements are not in a sequentially-descending order #622

Closed spaceninja closed 1 year ago

spaceninja commented 3 years ago

Properly ordered headings that do not skip levels convey the semantic structure of the page, making it easier to navigate and understand when using assistive technologies. Learn more

Failing Elements

h4 for User Name in sidebar on permalink page, and Shake Name in sidebar on shake page

FrankXenarthra commented 1 year ago

@spaceninja Do you refer to https://github.com/MLTSHP/mltshp/blob/master/templates/home/index.html#L168-L176 for both? Thanks for the clarification!

spaceninja commented 1 year ago

Nope, I was referring the user name/shake name in the sidebar when viewing a shake. This bug report came from running Lighthouse on the Shake page.

The example you linked to is actually in the correct order.

jessamynwest commented 1 year ago

@spaceninja Just making sure I'm understanding you. So like on this SHK page the SHK name is in h3 tags, I think?

https://mltshp.com/librarian

On my user page my user name is in h4 tags.

https://mltshp.com/user/jessamyn

On an example permalink page my user name is in h4 tags

https://mltshp.com/p/1P7AY

What should it be looking like when it's fixed?

spaceninja commented 1 year ago

I originally filed this bug because it came up when i ran a Lighthouse test on the site.

I've just re-run the test and it no longer flags this error. That means either we fixed it, or Lighthouse decided this wasn't something worth testing anymore. Either way, I think we can close this issue.

jessamynwest commented 1 year ago

Sounds good.