MLTSHP / mltshp

Source for the application that runs mltshp.com
https://mltshp.com/
Mozilla Public License 2.0
50 stars 21 forks source link

Only hide user avatar on user shake #644

Open spaceninja opened 3 years ago

spaceninja commented 3 years ago

Andrew Huff:

Random question: Is there a reason that one’s own posts don’t show one’s avatar? It’s a rather odd break in the UI.

Brad Choat:

I imagine it was done to keep user shakes from showing the same userpic for each and every post, since the shake itself gives context. Should probably be shown consistently for other contexts, though.

Andre Torrez:

Yup. I believe it’s just reusing the same element that it’d use in your shake and that one didn’t have an avatar attached. Makes sense it’d use one in other contexts.

Andrew Huff:

Gotcha. Well, it’s obviously not a high priority change, but I think it would make sense to update for consistency in non-user shake contexts.


Expected outcome: User avatars should only be hidden when viewing that user's personal Shake.

This may require an update to the patterns repo, but I think it can be done entirely in the templates in this repo.