search

MLTSHP / mltshp

Source for the application that runs mltshp.com
https://mltshp.com/
Mozilla Public License 2.0
50 stars 21 forks source link

Fix issue with member not being removed from shake #703

Closed AbrhamSayd closed 1 year ago

AbrhamSayd commented 1 year ago

Hey everyone,

I just wanted to share a quick update on my contribution to the project. After investigating the issue #701 with members not being removed from the shake, I found that the members template was missing the "remove-from-shake-button-link" class in the anchor tag of the remove button. This was preventing managers from being properly removed from the shake.

I recorded a short video showing how managers can now be removed from the shake without any issues:

ezgif-4-a466323ac2

AbrhamSayd commented 1 year ago

@spaceninja FYI

spaceninja commented 1 year ago

Interesting — No objection to the code, if it fixes things, but I'll admit to being mystified as to how the absence of a class prevents the code from work? Is there some JS hooked up to the class somewhere?

spaceninja commented 1 year ago

Okay, I went and looked, and yes, there is JS attached to this class, which is why the button wasn't doing anything before. Good catch, thanks!

https://github.com/MLTSHP/mltshp/blob/4e148b5c9af95cfa229b815be2317aa51e2ae97a/static/js/main.js#L1606