MLTSHP / mltshp

Source for the application that runs mltshp.com
https://mltshp.com/
Mozilla Public License 2.0
50 stars 21 forks source link

Fixing a race condition affecting sign-up form #726

Closed bradchoate closed 1 year ago

bradchoate commented 1 year ago

In some cases, the submit button sends the sign-up request ahead of the reCaptcha token request.

jessamynwest commented 1 year ago

So cool you figured this out.

dphiffer commented 1 year ago

It looks like this would work as a fix for the problem as described. I'm trying to understand is why this click handler exists in the first place. Shouldn't an <input type="submit"> already submit its parent form without the need for any JavaScript?

bradchoate commented 1 year ago

Perhaps, but trying to keep this change minimal.