search

MLTSHP / mltshp

Source for the application that runs mltshp.com
https://mltshp.com/
Mozilla Public License 2.0
50 stars 21 forks source link

Whitespace cleanup: Format Javascript #354 #730

Closed FrankXenarthra closed 1 year ago

FrankXenarthra commented 1 year ago

This commit used prettier command to cleanup the formatting of the javascript files. The following command has been used: prettier "./*/.js" --write

FrankXenarthra commented 1 year ago

@bradchoate I've seen that you approved a Pull Request for mltshp. I can't assign any reviewers for this one. Am I missing anything or do I just need to wait until someone is picking this up? Thanks for the help!

bradchoate commented 1 year ago

I'd remove the changes for static/straw/compact.js and static/js/jquery-min-1.4.2.js since those are meant to be minified in format. Would you mind adding a configuration file with an excludeFiles rule to exclude these two?

FrankXenarthra commented 1 year ago

Thank you for the review. I created a new pull request https://github.com/MLTSHP/mltshp/pull/731

The tests fail to fetch. Are the reasons the length of the commit title or that it doesn' t end with a number?

bradchoate commented 1 year ago

Closed in favor of #731