search

MLXXXp / Arduboy2

An alternative library for the Arduboy miniature game system
Other
266 stars 114 forks source link

Naming of the system font #66

Closed ace-dent closed 3 years ago

ace-dent commented 3 years ago

We call the standard 'system' font 5x7... but it's 5x8 px... See: https://community.arduboy.com/t/a-small-program-to-display-the-font/145/3

Check long descenders on 'p', 'g', etc. and also full height block graphics. Not sure if this can be renamed at this stage? Perhaps using a #define font5x7 font5x8 ...?

MLXXXp commented 3 years ago

The Arduboy system font is from the Adafruit glcdfont.c. In that file it's described as a 5x7 font, hence the name used in the Arduboy libraries.

font5x7 is declared as public. If there are any Arduboy sketches currently using it they will break if it were to be renamed. The documentation for font5x7 clearly indicates that it is 8 pixels high.

If a developer wishes to rename the font to make its size clearer, they can add a #define or using statement or whatever to their own sketch code.

ace-dent commented 3 years ago

Ok. Thanks for reviewing.