search

MLopez-Ibanez / irace

Iterated Racing for Automatic Algorithm Configuration
https://mlopez-ibanez.github.io/irace/
GNU General Public License v2.0
58 stars 14 forks source link

bug or feature in testing_fromlog? #33

Closed cokejac closed 1 year ago

cokejac commented 2 years ago

Hello manuel, using irace I noticed that the function testing_fromlog(...) on line 180 of the main.R file calls the function testing_common(...) but the result is not updated in the IraceResult object

180 testing_common(configurations, scenario, parameters, iraceResults)

as it happens in the line 229 of the function testing_fromfile(...).

229 iraceResults <- testing_common(configurations, scenario, parameters, iraceResults)

I don't know if this is a bug or a feature, unfortunately I don't know how to create a pull request. If you had a manual, I'd love to read it.

Cheers

MLopez-Ibanez commented 2 years ago

I don't know if this is a bug or a feature, unfortunately I don't know how to create a pull request. If you had a manual, I'd love to read it.

The reason is simply that the only use of testing_fromlog() in the irace.R does not need the output, so it is easier to return TRUE/FALSE to show success/failure (the output is saved in the logFile anyway). But if you find returning the output useful, I can change it. The functions are new, so this kind of feedback is very useful!

MLopez-Ibanez commented 2 years ago

unfortunately I don't know how to create a pull request. If you had a manual, I'd love to read it.

About creating pull requests: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/about-pull-requests

There is an irace user guide: https://mlopez-ibanez.github.io/irace/irace-package.pdf

MLopez-Ibanez commented 1 year ago

Hi, since there has been no activity on this, I guess you are happy with the answer. Please let me know otherwise.