fix: update ADRs

[MLopezJ]

changes made:

• remove the implementation decisions that were documented in the ADR folder.
  • The files removed were documents that talk about the default option to be selected when multiple instances or resources. This decision is documented in src/converter.spec.ts
• Updates ARD documents
  • Change document IDs
• Create tests that prove what the ARD document says.
• Create a test that proves what the Document folder says

[MLopezJ]

@CodiumAI-Agent /describe

[MLopezJ]

@CodiumAI-Agent /review

[CodiumAI-Agent]

PR Analysis

• 🎯 Main theme: Refactoring and updating tests

• 📝 PR summary: This PR focuses on refactoring and updating tests in the codebase. It removes some Architecture Decision Records (ADRs) and updates the references to these ADRs in the code. It also adds new tests and updates existing ones to reflect the changes made.

• 📌 Type of PR: Refactoring

• 🧪 Relevant tests added: Yes

• ⏱️ Estimated effort to review [1-5]: 3, because the PR involves changes in multiple files and the addition of new tests, which requires a careful review to ensure that the tests cover all the necessary cases and that the refactoring does not introduce any bugs.

• 🔒 Security concerns: No security concerns found

  PR Feedback

• 💡 General suggestions: The PR is well-structured and the changes are logically grouped. The removal of ADRs and the corresponding updates in the code are done correctly. The addition of new tests and the updates to existing ones are also well done. However, it would be beneficial to ensure that all edge cases are covered in the tests.

• 🤖 Code feedback:

  • relevant file: src/converter.spec.ts suggestion: Consider adding more edge cases to your tests to ensure robustness of the code. [medium] relevant line: void it(should trigger a warning if an 'Asset Tracker reported' object can not be created because equivalent LwM2M object is undefined, (context) => {

  • relevant file: src/utils/getRoam.spec.ts suggestion: It would be beneficial to add tests to check the behavior when the input is not as expected or is missing. [medium] relevant line: void it(should not create the 'band' and 'eest' keys from 'Roam' object, () => {

  • relevant file: src/utils/getDev.spec.ts suggestion: Consider adding tests to check the behavior when the input is not as expected or is missing. [medium] relevant line: void it(should not create the 'iccid' key from the 'Dev' object, () => {

  • relevant file: src/utils/getGnss.spec.ts suggestion: It would be beneficial to add tests to check the behavior when the input is not as expected or is missing. [medium] relevant line: void it(should not create 'hdg' from 'GNSS' object, () => {

How to use

Tag me in a comment '@CodiumAI-Agent' and add one of the following commands: /review [-i]: Request a review of your Pull Request. For an incremental review, which only considers changes since the last review, include the '-i' option. /describe: Modify the PR title and description based on the contents of the PR. /improve [--extended]: Suggest improvements to the code in the PR. Extended mode employs several calls, and provides a more thorough feedback. /ask \<QUESTION>: Pose a question about the PR. /update_changelog: Update the changelog based on the PR's contents.

To edit any configuration parameter from configuration.toml, add --config_path=new_value For example: /review --pr_reviewer.extra_instructions="focus on the file: ..." To list the possible configuration parameters, use the /config command.

[MLopezJ]

@CodiumAI-Agent /improve