MM2-0 / Kvaesitso

A search-focused Android launcher
https://kvaesitso.mm20.de/
GNU General Public License v3.0
2.5k stars 86 forks source link

[Issue] Poor performance in the app drawer #257

Open Terkyz opened 1 year ago

Terkyz commented 1 year ago

Kvaesitso works great and with each update it gets faster, but at least on my device (Samsung A10, 2GB), in the app drawer the performance is noticeably worse than in the main menu of the launcher, and in fact gives the feeling that it moves slower or is "heavier" when moving the finger.

I have noticed that the more apps you have, the greater the feeling of "heaviness" and is that the horizontal line where applications appear is noted that takes longer to load, because you see how it appears and apps are accommodated, while with the apps above this does not happen.

I have made several comparisons (although this does not mean anything, because not all launchers are made equal) and I do not have this problem with all launchers, but with some, and the common factor of "heaviness" is always the number of installed apps.

Here is a small example of the "heaviness".

htaige commented 1 year ago

I am experiencing the same issue on my Galaxy s10+. It is especially bad after booting the device as the launcher loads all the icons for the apps. The scrolling performance for the app drawer and the transition swipe to access the app drawer feel noticeably more sluggish when compared to other launchers.

jspivey40 commented 1 year ago

Basically same thing here. Stuttering and hiccups or heaviness in many areas, and it does seem like it's worse with more apps installed. This is one of my favorite launchers, but the heaviness is a bit much for my stylus 5g

Terkyz commented 1 year ago

Title corrected.

montchr commented 1 year ago

Same here on Pixel 7 Pro. It's also quite noticable during inter-layout transitions e.g. going from home to drawer and back. Would not be as disorienting if there were a way to disable or adjust animation/motion settings for those transitions, but obviously the drawer itself still needs to handle motion smoothly.

exstntlmsnthrp commented 1 year ago

Interesting. I'm using the Pixel 7 Pro and I do not seem to notice these problems. I've used it on both stock Android and I'm currently using LineageOS with no problem.

russianbot91 commented 1 year ago

I think a good solution would be the ability to change the animation speed within the launcher settings.

I use a Pixel 6a and have the animation scale set to 0.5x in Developer Settings, but I think the animations in Kvaesitso could be sped up.

rohitghali commented 1 year ago

Yep. Can confirm. Suffering the same here. It's like scrolling at low refresh rate. OnePlus 7t pro here.

kinesight commented 1 year ago

Same issue here on Samsung Galaxy A52s - OneUI 4.1 (Android 12)

MM2-0 commented 1 year ago

Can you check if that build improves anything for you?

app-default-release.zip

Terkyz commented 1 year ago

I have been testing it and the difference is noticeably better. At first for some reason (I do not know if it is related to the launcher) the keyboard seems to take a while to appear and the apps at first have that effect of "heaviness" but really after a moment and goes very smooth and fast.

MM2-0 commented 1 year ago

the apps at first have that effect of "heaviness" but really after a moment and goes very smooth and fast.

I have improved the caching so resources are reused more efficiently, but the first load remains unchangd so that's to be expected.

MM2-0 commented 1 year ago

If you're still having performance issues on version 1.24.2, can you please test whether the following settings affect the performance of the app drawer in any way (settings > grid & icons)?

And it would also be helpful to know how many different apps you have in your app drawer.

Please also state your device.

Thanks.

Terkyz commented 1 year ago

The themed icons are disabled by default in my system, so it can be discarded as an option.

I tried different icon shapes and I definitely noticed a change, I have the feeling that the square is the fastest, while the circle is pretty fast too.

Once you have the icons in circular shape and the labels disabled, it is VERY FLUID.

Here I edited a short video where you can better appreciate the performance difference, I could not add when I change the number of columns due to lack of space unfortunately.

I have 66 applications in the app drawer, and two hidden.

yant0 commented 1 year ago

I face the same issue yesterday, i decide to open up the apps's setting and i forgot that i had battery optimization on. After turning it off, its running smooth although still choppy (~18fps). I have an android 11 sd600 3gb ram.

Akselmo commented 1 year ago

I have same issue on Fairphone 3+. If I could disable the physics based animations and translucency in cards, I think that would help.

dongltron commented 1 year ago

Hey there, I can also confirm the laggy performance on Pixel 7 Pro. It's not awful but definitely noticeable at 120Hz. Disabling labels seems to help (that's how I prefer it anyway), but still definitely a noticeable drop in performance. If I can help in any way let me know, totally willing to test a build or troubleshoot :)

dongltron commented 1 year ago

Hey there, I can also confirm the laggy performance on Pixel 7 Pro. It's not awful but definitely noticeable at 120Hz. Disabling labels seems to help (that's how I prefer it anyway), but still definitely a noticeable drop in performance. If I can help in any way let me know, totally willing to test a build or troubleshoot :)

https://imgur.com/a/SmqUnyg

Here's a link to my experience. Definitely not as bad as the S10 example above but still notable.

dongltron commented 1 year ago

Update: So, to me, the poor performance appears to be something to do with the keyboard? Upon updating to the latest version, 1.25.0, the performance has straightened itself out, but only when the keyboard is closed. Upon opening it (therefore when the keyboard opens) the performance is laggy as usual. As soon as it is closed, to my eyes at least, it's 120Hz.

Video provided below. Hopefully this helps to narrow down the issue?

https://imgur.com/a/6T4tjlK

dongltron commented 1 year ago

Disabling 'Open keyboard' fixes the lag entirely. I'm almost certain it's something to do with the keyboard itself.

Akselmo commented 1 year ago

Disabling 'Open keyboard' fixes the lag entirely. I'm almost certain it's something to do with the keyboard itself.

Unfortunately not on Fairphone 3+. But this phone has way less resources anyhow.

dongltron commented 1 year ago

Ah okay yeah I didn't mention it here because I did above but just in case people miss it this is on a Pixel 7 Pro, so yeah definitely punching above the Fairphone's weight. Hopefully not too hard to fix once they pinpoint the issue. Seems they have taken the necessary steps for the rest of the scrolling though, just the keyboard left to optimise (I think?)

MM2-0 commented 1 year ago

I think the keyboard issue is somehow related to this: #370

Akselmo commented 1 year ago

I feel like for me the FPS drop happens when the app icons are loaded.

projjalm commented 1 year ago

I think the cause(s) of this FPS drop are not one, but many, because I've been testing the app recently and noticed it happens under very different situations.

It first happens when you start the app after a force stop (or after other actions I didn't test with it yet) and pull up/down to the drawer/widgets WITHOUT waiting for some seconds (to let it cache stuff?). It generally happens whenever app icons are getting loaded, that is, on app start in favorites row or drawer.

Then, most importantly, it happens when the keyboard gets enabled while in the drawer (synonymous to the search box getting clicked).

And also about the linked issue, @MM2-0 while the behavior (glitch) of the keyboard maybe linked to the above cause, the FPS drop happens regardless of the glitch (that is, keyboard opening and closing in a short period of time).

MM2-0 commented 1 year ago

And also about the linked issue, @MM2-0 while the behavior (glitch) of the keyboard maybe linked to the above cause, the FPS drop happens regardless of the glitch (that is, keyboard opening and closing in a short period of time).

It's just a theory, but maybe something triggers the keyboard to show and hide multiple times in a row which

  1. Forces the layout to remeasure everytime the keyboard state changes (hence the lag)
  2. Can produce the visual glitch that is described in the other issue (however I believe that the glitch is not always visible as it might depend on other factors as well, e.g. how long the keyboard takes to open)
mjain234 commented 1 year ago

First, I want to give thanks to the developer for this awesome launcher he built and hope so he still continues to do till infinity. I also faced a lag while doing a search in app drawer. I have read all the comments here and followed the same by disabling labels, choose icon shape to circle too and change the column to 3 but the lag is still noticible as you can see here.

1)Whenever swiping and keyboard shows, there's a small lag noticeable, also 2)when you scroll up in app drawer and also 3) sometimes when you exit app and go to home screen.

mjain234 commented 1 year ago

First, I want to give thanks to the developer for this awesome launcher he built and hope so he still continues to do till infinity. I also faced a lag while doing a search in app drawer. I have read all the comments here and followed the same by disabling labels, choose icon shape to circle too and change the column to 3 but the lag is still noticible as you can see here.

1)Whenever swiping and keyboard shows, there's a small lag noticeable, also 2)when you scroll up in app drawer and also 3) sometimes when you exit app and go to home screen.

Also, while in home screen, there are some scrollable widgets where I am not able to scroll properly, whenever I do instead of scrolling in the widgets itself, it gets scrolled in main screen itself. See here

hrueschwein commented 1 year ago

I've faced this bug today after firmware update on my Honor X9a. Disabling keyboard launching helped, but when I clicking at search bar from main screen or app drawer this lag is notable.

Huge gratitude for developing Kvaesito and maintaining it!:)

rahaaatul commented 1 year ago

Disabling keyboard launching helped, but when I clicking at search bar from main screen or app drawer this lag is notable.

I can confirm this. It does the same thing in my device, here's a screen record @MM2-0 :

https://github.com/MM2-0/Kvaesitso/assets/86149861/67bd6829-4c59-49d0-b3a2-de6adeb98afa

gromoslaw-kroczka commented 1 year ago

Could be related to #577 ?

dongltron commented 1 year ago

Happy to report that 1.28.0 appears to have completed fixed these issues.

Pixel 8 Pro on Android 14

TheDeadCell commented 1 year ago

After 1.28.0, still experiencing this issue on Oneplus Nord N10 android 11.

Sir-Photch commented 1 year ago

Unfortunately, since GrapheneOS moved to Android 14, Kvaesitso just gets super laggy after each update on my Pixel 7 Pro. While reinstalling the app fixes that problem, this is not really a solution.

Rolv-Apneseth commented 1 year ago

I'm also on GrapheneOS and it's the same deal for me, app only gets super laggy after an update and re-installing fixes it. I was wondering if it was something to do with the app optimisation it does after each update but maybe not if a bunch of other phones are also having the same issue?

exstntlmsnthrp commented 1 year ago

This must have to do with grapheneos and the post update optimizations that others reference. To my knowledge, every variation of Android does these optimizations to some extent or other after each update. I also have a Pixel 7 pro, but I have LineageOS installed and do not have this problem.

To be fair, I have noticed issues with other apps after system updates, just not kvaesitso.

Terkyz commented 11 months ago

I have switched my phone to a Samsung Galaxy A32 running Android 12 and this problem is completely fixed, while on my previous device it is still the same.

Sir-Photch commented 11 months ago

Instead of reinstalling on GrapheneOS, you may also try to switch back to the default launcher, disable Kvaesitso and clear it's cache, restart your phone for GOS to re-optimize, and then re-enable it as a launcher. This will keep your configuration (esp. the non-exportable).

Seems to me that apps that have access to gestures / are set as a launcher do not get optimized.

Edit: it also works for me without clearing the cache. So the steps after an upgrade are:

  1. wait until grapheneos has optimized all apps, if kvaesitso is laggy, continue
  2. switch to the default launcher
  3. deactivate kvaesitso in the device app settings
  4. reboot your phone
  5. wait for GOS to optimize again, if prompted, tap to restart optimized apps
  6. re-set kvaesitso as your launcher
exstntlmsnthrp commented 11 months ago

That's a good point @Sir-Photch. What about Debug > Clean up database? Would that help with anything related to this?

Sir-Photch commented 11 months ago

~IIRC this will remove your configuration of the launcher.~

Oh you mean in the launcher settings. I don't think this will change anything though.

Sir-Photch commented 11 months ago

Actually, this may be fixed for GOS users since the latest update. (https://github.com/GrapheneOS/os-issue-tracker/issues/2526) Can anyone else on GrapheneOS confirm this? It seems fine for me now.

exstntlmsnthrp commented 11 months ago

@Sir-Photch I agree with you. After I got the update yesterday, I've noticed that I never had to force stop, clear cache and reboot. I was wondering if something changed it it was just me.

Rolv-Apneseth commented 11 months ago

Same for me when updating yesterday, but I didn't notice an app optimising step either

jacekpoz commented 11 months ago

it has been better for me recently (latest GOS alpha) but there's still noticable lag, I don't think it's fixed yet

force stopping, clearing cache and rebooting also doesn't help

Rolv-Apneseth commented 10 months ago

Just did an update and the issue remains for me. This one did have the app optimising step.

Pentaphon commented 4 months ago

The app drawer is easily the slowest part of Kvaesitso even on the current version posted today.

Rolv-Apneseth commented 4 months ago

The problem described by this issue is solved I think, at least for me it's fine now. I'm sure the performance could be better, but imo it makes sense that the drawer is slower than anything else, it has to display the most.

rahaaatul commented 4 months ago

imo it makes sense that the drawer is slower than anything else, it has to display the most.

Use other app launchers and tell me if there's a slowdown in app drawer @Rolv-Apneseth. It's simply a coding issue somewhere.

Rolv-Apneseth commented 4 months ago

Fair. I guess it is good enough for me but is an issue for others