search

MM2-0 / Kvaesitso

A search-focused Android launcher
https://kvaesitso.mm20.de/
GNU General Public License v3.0
2.07k stars 60 forks source link

Migrate osm opening hours parsing to external library #900

Open Sir-Photch opened 5 days ago

Sir-Photch commented 5 days ago

closes #860. I have also added tests with JUnit. Not sure if you'd still want new test implementations to base on a Java-only testing library, but I figured since e.g. tests of :core:ktx also use JUnit I'd use that.

There are some TODOs left because I somehow underestimated how big of a raging dumpster fire the opening_hours spec actually is. ("sunrise to sunset" is a thing!)

MM2-0 commented 5 days ago

I have also added tests with JUnit. Not sure if you'd still want new test implementations to base on a Java-only testing library, but I figured since e.g. tests of :core:ktx also use JUnit I'd use that.

Afaik Android officially still only supports JUnit 4 as a testing library, so I'm fine with that.

There are some TODOs left because I somehow underestimated how big of a raging dumpster fire the opening_hours spec actually is. ("sunrise to sunset" is a thing!)

Oh no! :D

I'd like to publish a release today, so this will probably have to wait for the next version if that's alright?

Sir-Photch commented 5 days ago

I'd like to publish a release today, so this will probably have to wait for the next version if that's alright?

Sure, no problem. I'm not in a hurry :)