MMF-FE / svgicon

SVG icon components and tool set
https://mmf-fe.github.io/svgicon
MIT License
922 stars 95 forks source link

posibility of a 3.2.10 release with less strict svgo version dependency #172

Closed evansrobert closed 2 years ago

evansrobert commented 3 years ago

Hi, @Allenice,

Issue Description

I noticed that a vulnerability is introduced in vue-svgicon@3.2.9: Vulnerability CVE-2021-33587 affects package css-what (versions:<5.0.1): https://snyk.io/vuln/SNYK-JS-CSSWHAT-1298035 The above vulnerable package is referenced by vue-svgicon@3.2.9 via: vue-svgicon@3.2.9 ➔ svgo@1.3.2 ➔ css-select@2.1.0 ➔ css-what@3.4.2

Since vue-svgicon@3.2.9 (27,419 downloads per week) is referenced by 40 downstream projects (e.g., @spaceone/design-system 0.1.1-dev.135 (latest version), dfin-jkit 0.0.241 (latest version), base-ui-components 1.0.12 (latest version), aj-vue-ui 0.2.44 (latest version), luckystarry-ui 1.0.5 (latest version)), the vulnerability CVE-2021-33587 can be propagated into these downstream projects and expose security threats to them via the following package dependency paths: (1)@spaceone/design-system@0.1.1-dev.135 ➔ vue-svgicon@3.2.9 ➔ svgo@1.3.2 ➔ css-select@2.1.0 ➔ css-what@3.4.2 (2)aj-vue-ui@0.2.44 ➔ vue-svgicon@3.2.9 ➔ svgo@1.3.2 ➔ css-select@2.1.0 ➔ css-what@3.4.2 ......

If vue-svgicon@3.2.* removes the vulnerable package from the above version, then its fixed version can help downstream users decrease their pain.

Given the large number of downstream users, could you help update your package to remove the vulnerability from vue-svgicon@3.2.9 ?

Fixing suggestions

In vue-svgicon@3.2.10, maybe you can kindly try to perform the following upgrade : svgo ^1.0.5 ➔ ^2.3.1;

Note: svgo@2.3.1(>=2.3.1) transitively depends on css-what@5.0.1 which has fixed the vulnerability CVE-2021-33587. Of course, you are welcome to share other ways to resolve the issue.

Best regards, ^_^

Allenice commented 2 years ago

svgo updated, from ^1.3.2 to ^2.8.0, please update @yzfe/svgicon-loader@1.2.0, see change log.