Open MMK21Hub opened 2 years ago
A comment from Avoma on Mojira:
I've been informed by a Mojang Employee not to report these issues as instead, a Google Docs Spreadsheet that I created regarding all of the capitalization errors and inconsistencies within the advancement descriptions of advancements throughout the game, has been passed on internally, so I've been reassured that there's no need to create new tickets regarding these issues.
I'm not yet sure what implications this will have for this pack. (It's also intresting that Avoma was personally contacted regarding this issue; I assume that the rest of us should carry on reporting advancement description capitalisation bugs)
In 22w15a, 33 of the 97 issues from Avoma's Advancement Description Capitalisation Issues speadsheet have been fixed.
Fixes have been removed from the pack accordingly.
New bug for 22w15a: MC-250158 (The "Sneak 100" advancement description doesn't contain a serial comma where appropriate)
Fixed in commit 011d924c5c7f1cb14e90be76d80d096dbb62c716
https://bugs.mojang.com/browse/MC-250194 was created right as v2.4 was released :p
Since it only applies to the en_us
language, I'll have to rethink my method of just copy-pasting the whole file to keep both languages up-to-date.
MC-226430 has just been marked as fixed by 22w15a:
Resolving as fixed in 22w15a. Please create a new issue if there are remaining strings that still need to be fixed.
Fix removed in commit f80b5fe3f343709c29caa6fe519f7aad22caa598
The only remaining issue with the advancements is MC-226484.
Fixed in commit c14db5608b0871264d88291de0c171e14d923c29
New in 22w17a: MC-250932 (Goat Horn subtitles)
Fixed in commit 97c0f8bd82b8c217165b4e9905340d7bde80dd42
New in 22w18a: MC-251320 ("instrument.unregistered_sadface" displays raw translation string (is untranslated))
This has already been marked as Won't FIx by Mojang and the intended contents of the translation string isn't obvious, so I'll have to dig into the code to work out where exactly it's used and what its intended contents may be.
MC-250968 (The subtitle produced when goats' horns break off doesn't contain a possessive apostrophe where appropriate and incorrectly capitalizes the word "Horn") has had its translation string changed in 1.19-pre1, so I'll need to check that our fix is still correct.
Done
New in pre-release 5: MC-252408 - Chat restriction strings consist of inconsistent concluding punctuation
Fixed in commit 142fb9d6a19e27a50bf553f6f47b26e805d41871; shipped in release v2.7
Lots of issues with the new chat reporting function in 22w24a:
gui.abuseReport.reason.self_harm_or_suicide.description
translation stringgui.chatSelection.fold
translation string is unnecessarily capitalisedgui.abuseReport.reason.terrorism_or_violent_extremism.description
translation stringShipped in release v2.8
New bug for 1.19.1-pre2 (we're back to pre-releases :upside_down_face:)
Fixed in ca288c9a0394db10a2bb9bdeeb851c652c3d9483; shipped in v2.10
https://bugs.mojang.com/browse/MC-254428 seems correct anyway to me, so I'll wait for a triage by Mojang before adding it. I was correct: it's just been marked as WAI.
Fixing https://bugs.mojang.com/browse/MC-158539 will be fun
https://bugs.mojang.com/browse/MC-256422 Some words within some strings use right single quotation marks instead of apostrophes
What a poetic bug report description
Furthermore, they both render differently in Minecraft's font which may convey the idea that they serve different purposes from one another, thus potentially creating additional perplexity.
MC-257618 The "telemetry.event.world_loaded.description" string incorrectly spells the word "paired" as "pair"
Done
https://bugs.mojang.com/browse/MC-258246 "Telemetry Data" button has no ellipsis
Fixed in ca1540a
MC-219541 has been expanded and the pack no longer fully fixes it. (Avoma's comment)
Fix updated in 03e08fb
We'll need to fix MC-259360 - The Fixed in commit 54d904eselectWorld.mapFeatures.info
string is missing a comma before the word "etc"
Avoma's done what he does best and spotted another inconsistency: MC-264962 (References to keybinds with two keys are inconsistently formatted) Fixed in 95e958a13037acee8ae8da94f99dc931bc8ce185
MC-256422 has been updated to mention a new string: abuseReport.report_sent_msg
I managed to miss MC-188265 - The word "blocks" within some "/locate" command feedback messages is always pluralized
https://bugs.mojang.com/browse/MC-265583 "Incorrect pluralization for skin customization strings for pants" could be a bug, but I'll waste for this one to be triaged by Mojang
Check Avoma's Advancement Description Capitalisation Issues spreadsheetMC-250147 - Advancement descriptions for "Wax On" and "Wax Off" are inconsistentMarked as WAIMC-203095 -Fix implemented in 96cdc87/xp
feedback is always pluralized regardless of value outputMC-256885 - The word "messages" in the `gui.chatSelection.fold string is always pluralizedFixed in vanilla 22w45aMC-249663 (The subtitles of some parrot imitation sounds are inconsistent with the original sounds' subtitles) andgamerule.doTraderSpawning
When any new piece of information (that affects the pack) becomes available, I will add a comment. I will strike through the comment when it's been addressed.