search

MMRIZE / MMM-CalendarExt3

MagicMirror calendar view module
MIT License
58 stars 22 forks source link

Weather units do not match locale #63

Closed BigJoe1979 closed 1 year ago

BigJoe1979 commented 1 year ago

I'm in the US, where we stubbornly use different units than the rest of the civilized world.

I have my MM config set for locale: "en-US", and the weather module displays temps in F whereas CalendarExt3 displays them in C. Is there a setting I can change this?

eouia commented 1 year ago

I'll try to guess what happened

eouia commented 1 year ago

Just only unit is false? Or the value itself is calculated as Celsius than Fahrenheit?

eouia commented 1 year ago

Hmmm, weird. Nothing seems wrong in my module. Because, My module doesn't handle any unit from weather information, even C or F, anything. Could you show me your weather module configuration? (only except API Key) Are you using openweathermap API or other else?

eouia commented 1 year ago

I found out what was wrong. The broadcasting messages of the default weather module don't respect the units of the configuration of the weather module. Internally, it gets metric units from API by default and then converts them into imperial units to show in MagicMirror when configured as imperial but broadcasts the unconverted original metric values. So this is not the fault of my module. Ask MichMich or someone to fix the default weather module.