search

MMS-Projects / copyit-app

This repository contains the desktop and Android app of CopyIt
http://copyit.dev.mms-projects.net/
4 stars 2 forks source link

Login activity leaks #45

Open Marlinc opened 11 years ago

Marlinc commented 11 years ago

08-20 12:08:36.791: E/WindowManager(14212): Activity net.mms_projects.copy_it.ui.android.LoginActivity has leaked window com.android.internal.policy.impl.PhoneWindow$DecorView{4200dda8 V.E..... R.....ID 0,0-777,252} that was originally added here 08-20 12:08:36.791: E/WindowManager(14212): android.view.WindowLeaked: Activity net.mms_projects.copy_it.ui.android.LoginActivity has leaked window com.android.internal.policy.impl.PhoneWindow$DecorView{4200dda8 V.E..... R.....ID 0,0-777,252} that was originally added here 08-20 12:08:36.791: E/WindowManager(14212): at android.view.ViewRootImpl.(ViewRootImpl.java:345) 08-20 12:08:36.791: E/WindowManager(14212): at android.view.WindowManagerGlobal.addView(WindowManagerGlobal.java:239) 08-20 12:08:36.791: E/WindowManager(14212): at android.view.WindowManagerImpl.addView(WindowManagerImpl.java:69) 08-20 12:08:36.791: E/WindowManager(14212): at android.app.Dialog.show(Dialog.java:281) 08-20 12:08:36.791: E/WindowManager(14212): at net.mms_projects.copy_it.ui.android.LoginActivity.onSessionStateChange(LoginActivity.java:102) 08-20 12:08:36.791: E/WindowManager(14212): at net.mms_projects.copy_it.ui.android.LoginActivity.onResume(LoginActivity.java:131) 08-20 12:08:36.791: E/WindowManager(14212): at android.app.Instrumentation.callActivityOnResume(Instrumentation.java:1192) 08-20 12:08:36.791: E/WindowManager(14212): at android.app.Activity.performResume(Activity.java:5211) 08-20 12:08:36.791: E/WindowManager(14212): at android.app.ActivityThread.performResumeActivity(ActivityThread.java:2780) 08-20 12:08:36.791: E/WindowManager(14212): at android.app.ActivityThread.handleResumeActivity(ActivityThread.java:2819) 08-20 12:08:36.791: E/WindowManager(14212): at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1298) 08-20 12:08:36.791: E/WindowManager(14212): at android.os.Handler.dispatchMessage(Handler.java:99) 08-20 12:08:36.791: E/WindowManager(14212): at android.os.Looper.loop(Looper.java:137) 08-20 12:08:36.791: E/WindowManager(14212): at android.app.ActivityThread.main(ActivityThread.java:5103) 08-20 12:08:36.791: E/WindowManager(14212): at java.lang.reflect.Method.invokeNative(Native Method) 08-20 12:08:36.791: E/WindowManager(14212): at java.lang.reflect.Method.invoke(Method.java:525) 08-20 12:08:36.791: E/WindowManager(14212): at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:737) 08-20 12:08:36.791: E/WindowManager(14212): at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:553) 08-20 12:08:36.791: E/WindowManager(14212): at dalvik.system.NativeStart.main(Native Method)

https://github.com/MMS-Projects/copyit-app/blob/bca3db8a4117f4b196cc392c3d85984f2d438488/android/src/net/mms_projects/copy_it/ui/android/LoginActivity.java

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

schoentoon commented 11 years ago

Without looking into code, are we using a dialog in here? On Aug 20, 2013 12:12 PM, "Marlin Cremers" notifications@github.com wrote:

08-20 12:08:36.791: E/WindowManager(14212): Activity net.mms_projects.copy_it.ui.android.LoginActivity has leaked window com.android.internal.policy.impl.PhoneWindow$DecorView{4200dda8 V.E..... R.....ID 0,0-777,252} that was originally added here 08-20 12:08:36.791: E/WindowManager(14212): android.view.WindowLeaked: Activity net.mms_projects.copy_it.ui.android.LoginActivity has leaked window com.android.internal.policy.impl.PhoneWindow$DecorView{4200dda8 V.E..... R.....ID 0,0-777,252} that was originally added here 08-20 12:08:36.791: E/WindowManager(14212): at android.view.ViewRootImpl.(ViewRootImpl.java:345) 08-20 12:08:36.791: E/WindowManager(14212): at android.view.WindowManagerGlobal.addView(WindowManagerGlobal.java:239) 08-20 12:08:36.791: E/WindowManager(14212): at android.view.WindowManagerImpl.addView(WindowManagerImpl.java:69) 08-20 12:08:36.791: E/WindowManager(14212): at android.app.Dialog.show(Dialog.java:281) 08-20 12:08:36.791: E/WindowManager(14212): at net.mms_projects.copy_it.ui.android.LoginActivity.onSessionStateChange(LoginActivity.java:102) 08-20 12:08:36.791: E/WindowManager(14212): at net.mms_projects.copy_it.ui.android.LoginActivity.onResume(LoginActivity.java:131) 08-20 12:08:36.791: E/WindowManager(14212): at android.app.Instrumentation.callActivityOnResume(Instrumentation.java:1192) 08-20 12:08:36.791: E/WindowManager(14212): at android.app.Activity.performResume(Activity.java:5211) 08-20 12:08:36.791: E/WindowManager(14212): at android.app.ActivityThread.performResumeActivity(ActivityThread.java:2780) 08-20 12:08:36.791: E/WindowManager(14212): at android.app.ActivityThread.handleResumeActivity(ActivityThread.java:2819) 08-20 12:08:36.791: E/WindowManager(14212): at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1298) 08-20 12:08:36.791: E/WindowManager(14212): at android.os.Handler.dispatchMessage(Handler.java:99) 08-20 12:08:36.791: E/WindowManager(14212): at android.os.Looper.loop(Looper.java:137) 08-20 12:08:36.791: E/WindowManager(14212): at android.app.ActivityThread.main(ActivityThread.java:5103) 08-20 12:08:36.791: E/WindowManager(14212): at java.lang.reflect.Method.invokeNative(Native Method) 08-20 12:08:36.791: E/WindowManager(14212): at java.lang.reflect.Method.invoke(Method.java:525) 08-20 12:08:36.791: E/WindowManager(14212): at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:737) 08-20 12:08:36.791: E/WindowManager(14212): at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:553) 08-20 12:08:36.791: E/WindowManager(14212): at dalvik.system.NativeStart.main(Native Method)

— Reply to this email directly or view it on GitHubhttps://github.com/MMS-Projects/copyit-app/issues/45 .

Marlinc commented 11 years ago

Yes a 'AlertDialog' that asks the user if he automatically wants to login using Facebook because he has authorized CopyIt to access Facebook.

schoentoon commented 11 years ago

Replacing that with a DialogFragment will probably fix this leak. On Aug 20, 2013 9:09 PM, "Marlin Cremers" notifications@github.com wrote:

Yes a 'AlertDialog' that asks the user if he automatically wants to login using Facebook because he has authorized CopyIt to access Facebook.

— Reply to this email directly or view it on GitHubhttps://github.com/MMS-Projects/copyit-app/issues/45#issuecomment-22969152 .

Marlinc commented 11 years ago

I'll take a look at it it today. Do you know the main cause of this problem?

schoentoon commented 11 years ago

Rotation. On Aug 21, 2013 11:03 AM, "Marlin Cremers" notifications@github.com wrote:

I'll take a look at it it today. Do you know the main cause of this problem?

— Reply to this email directly or view it on GitHubhttps://github.com/MMS-Projects/copyit-app/issues/45#issuecomment-23004013 .