MMTIS / QA

In this repository we track issues for the different National Access Points
0 stars 0 forks source link

IT-Bolzano-NeTEx: Issues #5

Open ue71603 opened 1 month ago

ue71603 commented 1 month ago

URL: https://nap-1926.it/nap/mmtis/public/catalog/Asset/9677 Country: IT Producer: info@sta.bz.it Problems:

TimetabledPassingTime must have an id

It is a bad idea not not give id to TimetabledPassingTime. Especially, when version is added.


                                <TimetabledPassingTime version="any">
                                    <StopPointInJourneyPatternRef ref="it:apb:StopPointInJourneyPattern:01B10A.24a-3-0030801:" version="3"/>
                                    <DepartureTime>09:36:00</DepartureTime>
                                </TimetabledPassingTime>

Having routes with empty pointsInSequence is problematic:

                        <Route id="it:apb:Route:82-142-24a-1-4/R:" version="any">
                            <LineRef ref="it:apb:Line:82142_.24a:" version="1"/>
                            <DirectionRef ref="it:apb:Direction:R:" version="any"/>
                            <pointsInSequence/>
                        </Route>

Remove the empty element <pointsInSequence/> works, but is it what was intended?

Using ScheduldedStopPoints as RoutePointRef is not allowed

ScheduldedStopPoints are no RoutePoints


                    <routes>
                        <Route id="it:apb:Route:1-110-24a-2-1/H:" version="any">
                            <LineRef ref="it:apb:Line:01110_.24a:" version="2" />
                            <DirectionRef ref="it:apb:Direction:H:" version="any" />
                            <pointsInSequence>
                                <PointOnRoute id="it:apb:PointOnRoute:1-110-24a-2-1/H_1:" version="any" order="1">
                                    <RoutePointRef ref="it:apb:ScheduledStopPoint:it-22021-468-2-3086:" version="any" />
                                </PointOnRoute>
                                <PointOnRoute id="it:apb:PointOnRoute:1-110-24a-2-1/H_2:" version="any" order="2">
                                    <RoutePointRef ref="it:apb:ScheduledStopPoint:it-22021-468-3-5106:" version="any" />
                                </PointOnRoute>
                                <PointOnRoute id="it:apb:PointOnRoute:1-110-24a-2-1/H_3:" version="any" order="3">
                                    <RoutePointRef ref="it:apb:ScheduledStopPoint:it-22021-2084-0-5029:" version="any" />
                                </PointOnRoute>

StopPlaceentrance don't have coordinates

Why use them, when there are no coordinates available?

StopPlaceEntrance it:apb:StopPlaceEntrance:it-22024-97149: does not have a location or centroid.
StopPlaceEntrance it:apb:StopPlaceEntrance:it-22101-3281: does not have a location or centroid.
StopPlaceEntrance it:apb:StopPlaceEntrance:it-22101-3281: does not have a location or centroid.
skinkie commented 1 month ago

The Route may be a thing used as facade to get from ServiceJourney -> ServiceJourneyPattern -> Line.

ue71603 commented 1 month ago

If routes without a list of ScheduledStopPoints are ok for you, then it is fine with me as well.

skinkie commented 1 month ago

They are never ScheduledStopPoints, it should have RoutePoints.

ue71603 commented 1 month ago

Actual situation:

                        <Route id="it:apb:Route:1-110-24a-2-1/H:" version="any">
                            <LineRef ref="it:apb:Line:01110_.24a:" version="2" />
                            <DirectionRef ref="it:apb:Direction:H:" version="any" />
                            <pointsInSequence>
                                <PointOnRoute id="it:apb:PointOnRoute:1-110-24a-2-1/H_1:" version="any" order="1">
                                    <RoutePointRef ref="it:apb:ScheduledStopPoint:it-22021-468-2-3086:" version="any" />
                                </PointOnRoute>
                                <PointOnRoute id="it:apb:PointOnRoute:1-110-24a-2-1/H_2:" version="any" order="2">
                                    <RoutePointRef ref="it:apb:ScheduledStopPoint:it-22021-468-3-5106:" version="any" />
                                </PointOnRoute>
                                <PointOnRoute id="it:apb:PointOnRoute:1-110-24a-2-1/H_3:" version="any" order="3">
                                    <RoutePointRef ref="it:apb:ScheduledStopPoint:it-22021-2084-0-5029:" version="any" />
                                </PointOnRoute>
                                <PointOnRoute id="it:apb:PointOnRoute:1-110-24a-2-1/H_4:" version="any" order="4">
                                    <RoutePointRef ref="it:apb:ScheduledStopPoint:it-22021-467-0-5027:" version="any" />

But why does it validate?

skinkie commented 1 month ago

You mean why does the empty pointsInSequence vallidate? Likely because we cannot do logical-or in the XSD checks. I think pointsInSequence and/or linksInSequence should be provided.

ue71603 commented 1 month ago

no the sequence with ScheduledStopPoints validates. You said this can't be ScheduledStopPoints. Nevertheless they are valid:


                                <PointOnRoute id="it:apb:PointOnRoute:1-110-24a-2-1/H_2:" version="any" order="2">
                                    <RoutePointRef ref="it:apb:ScheduledStopPoint:it-22021-468-3-5106:" version="any" />
                                </PointOnRoute>
skinkie commented 1 month ago

Oh, I am surprised this is allowed.

ue71603 commented 1 month ago

In XML Spy it was. Can you check it with your tools, too?