search

MNGuenther / allesfitter

allesfitter is a convenient wrapper around the packages ellc (light curve and RV models), dynesty (static and dynamic nested sampling) emcee (Markov Chain Monte Carlo sampling) and celerite (Gaussian Process models).
MIT License
60 stars 36 forks source link

Wotan not really optional #31

Closed jvines closed 3 years ago

jvines commented 3 years ago

Hi,

I was trying to run allesfitter without wotan installed and it wouldn't run as it wouldn't import flatten in time_series and thus fail in lightcurves when trying to import flatten.

Cheers

MNGuenther commented 3 years ago

Hi José,

Can you replace your local file lightcurves.py with this one - lightcurves.txt - and let me know if it solves things? If it does, I can go ahead and push 1.2.4. (You'll need to rename it from .txt into .py manually because github prohibits attaching .py files)

I think the issue is that I had my own function called flatten in time_series, but apparently I decided some time ago to remove it and use wotan's flatten instead. But the old lightcurves.py still tried to import my own flatten from time_series.

The general allesfitter user actually doesn't need any of these functions, they are just for making fancy TESS plots or searching for transits etc. So wotan should remain optional, indeed.

Best Max

MNGuenther commented 3 years ago

Solved with version 1.2.4.