search

MNGuenther / allesfitter

allesfitter is a convenient wrapper around the packages ellc (light curve and RV models), dynesty (static and dynamic nested sampling) emcee (Markov Chain Monte Carlo sampling) and celerite (Gaussian Process models).
MIT License
60 stars 36 forks source link

TTVs transit numbers differ #47

Closed martindevora closed 2 years ago

martindevora commented 2 years ago

Hi, while trying out the TTVs module I realized about something. When I open the ttpvs-per-transit plot of my second candidate, the transit numbering differs to the TTVs initial guess transit numbering. See attached image: image You can see that transit 5 data is skipped in the initial_guess plot (right) and then its transit 5 matches the ttv_preparation transit 6. I guess this is somehow related to the transit lacking some data, but the point is that the numbering should be kept. I don't know whether this is also related to the transit fit missing the model at all (I only see the baseline).

In addition, this also would be affecting the final TTVs plot. See next attached image: image You can see that the transit 6 ttv from the final fit doesn't match the 6th point in the graph, but the 7th. I'm guessing that the transit numbering is matching the ttvs_preparation stage one instead of the transit numbering from the fit. Hence the mess. If this was the case, I don't know where the transit 5 data was obtained either.

Sorry if it sounds chaotic, but these are only some previous findings I've been getting. For clarity purposes, I'm also attaching my entire allesfitter working dir: https://drive.google.com/file/d/18t--3SnycEIjBxgYkNKr5S8uYiGu1uc9/view?usp=sharing

MNGuenther commented 2 years ago

Hm, I think I see what's happening here. Thanks for sharing the directory. Will look into it!

MNGuenther commented 2 years ago

Hi @martindevora, I think this should be fixed now that I updated the modules. I lost access to your Google Drive folder from above unfortunately. If this re-occurs or persists, please feel free to open this again!