MNGuenther / allesfitter

allesfitter is a convenient wrapper around the packages ellc (light curve and RV models), dynesty (static and dynamic nested sampling) emcee (Markov Chain Monte Carlo sampling) and celerite (Gaussian Process models).
MIT License
60 stars 36 forks source link

fix bug when opening derived results #64

Closed martindevora closed 1 year ago

martindevora commented 1 year ago

A path if checks for existence, but then a different path is used to open the file.

Aims to fix https://github.com/MNGuenther/allesfitter/issues/57

martindevora commented 1 year ago

Hello,

are you planning to review and merge this any time soon? If not, it'd be cool to let contributors become maintainers of the repository so it doesn't get abandoned and at least the easy code fixes could be pushed. The other scenario would be to start using my own fork and plug it into my package, as I'm beginning to consider as an option now; that is undesirable, though.

Kind regards.

MNGuenther commented 1 year ago

Thanks @martindevora!

Interesting idea about the change to direct contributors. Given my new role, I am no longer able to provide any support for feature requests. At the moment, I have too many local changes that I want to wrap up eventually and push to /main, before I would feel confident with such a system change. I hope to find time again in by Q4 2023 to clean things up and then we can see how to move on.