MNGuenther / allesfitter

allesfitter is a convenient wrapper around the packages ellc (light curve and RV models), dynesty (static and dynamic nested sampling) emcee (Markov Chain Monte Carlo sampling) and celerite (Gaussian Process models).
MIT License
62 stars 36 forks source link

np.float deprecated #74

Open MichaelW-B opened 9 months ago

MichaelW-B commented 9 months ago

In using GUI.ipynb with allesfitter 1.2.10 and Numpy 1.26.4 at section 5 "Check" there is an AttributeError --> 291 self.settings['fast_fit_width'] = np.float(self.settings['fast_fit_width']) 292 else: 293 self.settings['fast_fit_width'] = 8./24. AttributeError: module 'numpy' has no attribute 'float'.

I understand np.float was deprecated in an earlier version of Numpy and 'float' suggested for use but please advise whether the best solution to fixing this is to revert to an earlier vis of Numpy (in which case which one) or best other recommendation, thank you.

MNGuenther commented 9 months ago

Hi @MichaelW-B - Thanks for reaching out!

I would recommend to simply amend your local file(s) and replace the "np.float" with "float".

I can take note of updating this in a future release of allesfitter, but I'm afraid there is no foreseen release date for a new version right now. Still, please keep me posted if you find any other things that are deprecated by now.

MichaelW-B commented 9 months ago

Thank you

From: Maximilian N. Günther @.> Date: Friday, 16 February 2024 at 10:47 To: MNGuenther/allesfitter @.> Cc: Michael Waller-Bridge @.>, Mention @.> Subject: Re: [MNGuenther/allesfitter] np.float deprecated (Issue #74)

Hi @MichaelW-Bhttps://m365.eu.vadesecure.com/safeproxy/v4?f=h745bNMGJiL-PUr0PxTat1WSuey980M49CEreHKn7HsMYFhBautg-wJvlkqGc1kf&i=MAqkgiE1mKct8wYXQVJBUA02_WA3NswnGAD1wI0CHdmEYE2YMGXgor9swgNUUKJWzAd9CcEnkNrns5MLLpW4Ag&k=5mTe&r=fX-w28AxUpNTVVOlzhjTrk9FV0V7_jyUTJveznrVEkLQotHUKIXsokJTh_Qq8Db4&s=b2e7e801ddf88271aa149fb45089d1be563598d843c16932edf4fd042420b664&u=https%3A%2F%2Fgithub.com%2FMichaelW-B - Thanks for reaching out!

I would recommend to simply amend your local file(s) and replace the "np.float" with "float".

I can take note of updating this in a future release of allesfitter, but I'm afraid there is no foreseen release date for a new version right now. Still, please keep me posted if you find any other things that are deprecated by now.

— Reply to this email directly, view it on GitHubhttps://m365.eu.vadesecure.com/safeproxy/v4?f=3e13sbwKtd4Pc_bfHgxdngV6pR9aihCsmQ_qqEbzVE-zYk-oZxvwXo0oHmqDJb8C&i=cvNYE4NGhCzH1IbBX9tx2HWgR0eYRxjIayqvgQKd069iKjlb5B6I_lXWS67pYBwo3rGGi91PrmWafeS_k_GsIQ&k=JvLj&r=3uLI76wR2IABn4Ad4ErGpP5uYxcUvzRGXEKzr5OG8L0KoDCTs--uFylZI8TGUFR9&s=2741d9e31ee78045b0d2333732827e9fd96c01a51de689a281a79122aaa77613&u=https%3A%2F%2Fgithub.com%2FMNGuenther%2Fallesfitter%2Fissues%2F74%23issuecomment-1948154219, or unsubscribehttps://m365.eu.vadesecure.com/safeproxy/v4?f=VNNh5hYzFAsLMeIZR4V8y8uyYop9KeAExPfAvosVq-H7Xeex7RbN66WfoO56k1wp&i=C8AGnRXgoljyBVy094rQwRDJT7hgDHVMjgH-tUT0Z2wDFTq_CKRBBvQcAnoMhnJI_NKoE6XotIB2980Ko81nJw&k=LCz5&r=78DVFRTaqz6REA3VOEmi5IiuuclPg8Vk5Zrz7FDpDyiD02-7oifQbVn0iaNjtCBo&s=21dbc5cba32ae13442d9b43a3488b078329b984a6d4b9719a9c0c789005e1e65&u=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAXW6G7VOL6WH4VWZBGJMA2LYT42LFAVCNFSM6AAAAABDLZMI5CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNBYGE2TIMRRHE. You are receiving this because you were mentioned.Message ID: @.***>