MNoya / Element-TD

Element Tower Defense
http://www.eletd.com
64 stars 22 forks source link

Direct attacks no longer deal damage #456

Closed WindStrike72 closed 7 years ago

WindStrike72 commented 7 years ago

As of the latest Dota 2 patch, it broke yet even more bloody things. Here's the thingy that popped up in console every time a direct hit tried to deal damage:

[ Developer ]: scripts/vscripts/towers/basic/WaterTower.lua:19: GetAverageTrueAttackDamage called with 1 arguments - expected 2 [ Developer ]: stack traceback: [ Developer ]: [C]: in function 'GetAverageTrueAttackDamage' [ Developer ]: scripts/vscripts/towers/basic/WaterTower.lua:19: in function <scripts/vscripts/towers/basic/WaterTower.lua:17> [ Developer ]: ...ddons\element_td\scripts\vscripts\towers\towerevents.lua:14: in function <...ddons\element_td\scripts\vscripts\towers\towerevents.lua:3> [ W VScript ]: Script Runtime Error: scripts/vscripts/towers/basic/WaterTower.lua:19: GetAverageTrueAttackDamage called with 1 arguments - expected 2 [ W VScript ]: stack traceback: [ W VScript ]: [C]: in function 'GetAverageTrueAttackDamage' [ W VScript ]: scripts/vscripts/towers/basic/WaterTower.lua:19: in function <scripts/vscripts/towers/basic/WaterTower.lua:17> [ W VScript ]: ...ddons\element_td\scripts\vscripts\towers\towerevents.lua:14: in function <...ddons\element_td\scripts\vscripts\towers\towerevents.lua:3>

And that wasn't just Water tower, it was other towers too.

From what I could tell, ability damage still worked, cause Flooding Tower was still hurting stuff.

WindStrike72 commented 7 years ago

Fixed this and updated main client.

MNoya commented 7 years ago

Yeah Valve updated the API function GetAverageTrueAttackDamage to require an useless extra argument because whothehellknows

wang37921 commented 5 years ago

Yeah Valve updated the API function GetAverageTrueAttackDamage to require an useless extra argument because whothehellknows

thanks!