MNoya / Element-TD

Element Tower Defense
http://www.eletd.com
64 stars 22 forks source link

Dota 7.00 Patch #479

Closed MNoya closed 7 years ago

MNoya commented 7 years ago

As you might know by now, a huge dota patch was just released in test client yesterday and it's meant to hit the main client by today.

It's UI changes will most likely make the game very awkward if not unplayable. I'm not sure if we'll have ability/mechanic issues but it's likely.

Please report any problem caused by the patch under the 'Dota 7.00' milestone, My free time between work and december exams but I'll try to assist and fix everything that breakes the game.

biax commented 7 years ago

If you're going to make UI changes, would it consume too much of your time to include the statistics feature (during terrain-selection phase) I mentioned earlier?

I can draw a full proper mockup very quickly if you can do so. I believe this is a little out of my capability.

On 2016-12-12 19:02, Martin Noya wrote:

As you might know by now, a huge dota patch was just released in test client yesterday and it's meant to hit the main client by today.

It's UI changes will most likely make the game very awkward if not unplayable. I'm not sure if we'll have ability/mechanic issues but it's likely.

Please report any problem caused by the patch under the 'Dota 7.00' milestone, My free time between work and december exams but I'll try to assist and fix everything that breakes the game.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/MNoya/Element-TD/issues/479, or mute the thread https://github.com/notifications/unsubscribe-auth/AOdsCsOtHEKkBzmHo0tfBLJq6n4UqKtdks5rHSm-gaJpZM4LKbBF.

MNoya commented 7 years ago

Releasing a patch full of bug fixes asap should be the priority.

You can include the the stats feature mockup on #477 and I'll take a look at it after we close the critical issues first :smiley:

WindStrike72 commented 7 years ago

Visual bugs:

Performance bugs:

WindStrike72 commented 7 years ago

Summoning center hotkey appears to have gone borked as well.

ynohtna92 commented 7 years ago

Why is the map outside of the map box?

I will reduce the height of the player slots to make it fit better on the top bar. We should also put boxes around the bottom right stuff.

All the changes will so need to be tested on 3:4, 16:9, 16:10, 21:9

biax commented 7 years ago

screenshot_71

heres my input on tidying the UI while you're at it. @WindStrike72 do review

WindStrike72 commented 7 years ago

Another bug:

Regarding UI cleanup no jutsu from biax:

FYI, mah suggestions are intended as mainly a "if it's no real trouble compared to just fixing it".

Also, the screenshot I posted was in 16:9. I'll poke the Karawasanator to check out 21:9 and post a screenshot of how borked it is once fixes are applied. Dunno anyone w/ 4:3 or 16:10 though.

ynohtna92 commented 7 years ago

You can scale to 21:9 yourself if you set the width and height to the values I have commented in that .lua file.

biax commented 7 years ago

Is nobody updating eletd for 7.00? There are 1200 people playing it right now strangely. Ranked 4

On 2016-12-14 15:56, ynohtna92 wrote:

You can scale to 21:9 yourself if you set the width and height to the values I have commented in that .lua file.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/MNoya/Element-TD/issues/479#issuecomment-266967484, or mute the thread https://github.com/notifications/unsubscribe-auth/AOdsCvrN3qbRQVBpGJhqdcJTVG9d8GbJks5rH6FGgaJpZM4LKbBF.

WindStrike72 commented 7 years ago

Game of the day happened, though I'm surprised it jumped up that high, given there's multiple bug reports of people not being able to select elements, though I didn't get the issue on my end.

If Noya/Quint/etc. are willing to fix it, let's keep it to the bare minimum and just fix what's broken, not get all the other requested changes. I think there's still some backlog of balance changes that were applied already, so I can get the tooltips with them, don't think it was a whole lot of changes.

Karawasa commented 7 years ago

@biax Are you able to contribute? Currently, no one is working on updating for 7.00. Any and all help would be appreciated. I agree with @WindStrike72 that we should do the bare minimum.

biax commented 7 years ago

To do that, I will first need to know how to do it.. which neither me or wind knows

On 2017-01-19 04:03, Evan Hatampour wrote:

@biax https://github.com/biax Are you able to contribute? Currently, no one is working on updating for 7.00. Any and all help would be appreciate. I agree with @WindStrike72 https://github.com/WindStrike72 that we should do the bare minimum.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/MNoya/Element-TD/issues/479#issuecomment-273585264, or mute the thread https://github.com/notifications/unsubscribe-auth/AOdsChehRagBUS8cj1-3josXFwI4ZrCVks5rTnAOgaJpZM4LKbBF.

ynohtna92 commented 7 years ago

I just got back from being interstate so I can probably get started on some of the fixes. I just need clear reproducible bug reports to do things quickly. I'll tackle the game breaking issues first. Is there a priority list I could follow?

Karawasa commented 7 years ago

@ynohtna92 That is really great news! I'm not sure about a priority list. @WindStrike72 can you help with that?

WindStrike72 commented 7 years ago

I'll look into it, starting with the game breaking bugs list. Not sure if I can reproduce them, I recall trying some of them out, and it never crashed on my end. Might've been specific dota versions that were causing it. We'll see. I'll try to get this up in the next day.

biax commented 7 years ago

i'll list whatever issues i can find, of whatever priority:

in-game interface -- refer to: https://github.com/MNoya/Element-TD/issues/479#issuecomment-266844811

cosmetics issue: screenshot_89

reproducible crash (tested on my pc only so far, ill wait for some pals to help me test this later): start game -> sandbox -> pause and wait results in dota2 crashing. might need to scroll around a bit im not sure.

WindStrike72 commented 7 years ago

I'm not running into any crash errors personally anymore, buuut that doesn't mean they're not there.

In terms of visual bugs, I think they're all outlined above and are all still valid. Just do whatever fixes for those that's fastest, no need to do anything fancy.

I just ran a test of all the towers; functionally, they're all still perfectly fine, no visual bugs on them (I think), only thing that was out-of-place was having a pure dark w/ level 3 forge buff and its damage numbers almost going all the way across the portrait, which is hilarious, but hey, at least you can properly see buffed damage numbers now.

For priority list, check out the talent tree crash error and goat's sandbox error, and then after that, look into the visual bugs, which to my knowledge is mainly a bunch of floating UI stuff with missing backdrops.

ynohtna92 commented 7 years ago

https://github.com/MNoya/Element-TD/commit/e385f559868d0ef876c19b9b2c9d6b72c4c76bc7 Removed 700 UI additions and fixed the left side of the screen.

ynohtna92 commented 7 years ago

https://github.com/MNoya/Element-TD/commit/e43998cda2813ba1d6ecdb38a2229fe41a78ad4e Fixed top bar button layout.

ynohtna92 commented 7 years ago

I haven't been able to replicate any crashes or being unable to upgrade elements as the game is played. Can you provide more insight into this mechanic breaking?

biax commented 7 years ago

did you try sandbox + pause? i had crashes there (havent tested latest commits though)

On 2017-01-26 08:06, ynohtna92 wrote:

I haven't been able to replicate any crashes or being unable to upgrade elements as the game is played. Can you provide more insight into this mechanic breaking?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/MNoya/Element-TD/issues/479#issuecomment-275272415, or mute the thread https://github.com/notifications/unsubscribe-auth/AOdsCsCrK5IQ5fYPdTqoQjsxiCHBX3Raks5rV-OLgaJpZM4LKbBF.

Karawasa commented 7 years ago

I know this is low priority but I would actually like to play this again...so please fix ultra-wide resolution! I can post a screenshot of how it looks to me when I get home.

MNoya commented 7 years ago

you can play in windowed mode for the time being :sweat_smile:

ynohtna92 commented 7 years ago

https://github.com/MNoya/Element-TD/commit/bc6c86c800660e137777f7a4199648ce7bc78914 Fixes the layout for 21x9

@biax Yes I have tried and it works fine. It could be a dedicated server issue that I cannot reproduce.

I have noticed that onmouseover no longer is working for wave_info.xml. And I have no idea how to fix it. Our element level up panel also no longer exist.

You should be able to test and push these changes to the master for now so people stop complaining @WindStrike72. I will update the leaderboard tables as well so the correct ones are displaying.

WindStrike72 commented 7 years ago

I'm going ahead and pushing latest changes to public client since it fixes the talent tree crash error and few other UI things, though know I'm intending on running a follow-up patch w/ the actual changelog, tooltips, and remaining fixes you guys are working on. Thanks for taking the time to try and fix el broken doto!

Karawasa commented 7 years ago

Yes thank you guys!

MNoya commented 7 years ago

Alright if any other problem appears let's make a separate issue, game seems stable now.