search

MOARdV / DistantObject

Distant Object Enhancement bis plugin for Kerbal Space Program
51 stars 14 forks source link

Flares show up in front of the Sun when they shouldn't #26

Closed Kerbas-ad-astra closed 7 years ago

Kerbas-ad-astra commented 8 years ago

I see Jool on the face of the Sun, when it's actually around the back side (ca. Year 1 Day 84).

MOARdV commented 8 years ago

Yeah, I saw that a while back. I don't know if I have any info about the size of the Sun so I can determine occlusion.

drewcassidy commented 8 years ago

Im getting this issue with moho in version 1.7.2, ksp 1.1.3

screen shot 2016-07-02 at 12 38 03 pm screen shot 2016-07-02 at 12 37 58 pm
MOARdV commented 8 years ago

@drewcassidy - one problem may be that the "sun" that is visible in space isn't the same size as the "sun" in the database. Short of making a hack that ignores the size of the sun, I don't know what I can do about that. Although it may be that I messed something up and the feature isn't working correctly. I will look at it.

MOARdV commented 7 years ago

Checked the "flare in front of the sun" issue again. The problem is that the "sun" drawn in the skybox is much bigger than the radius provided in the Celestial Body (apparent size is 2x the radius of Kerbol, AFAICT). I am not going to introduce a hack to change the behavior, since it'll be entirely dependent on a stock KSP installation - something that affects sun flares would introduce a change in behavior that will generate complaints, so I'm closing this as "as good as it gets".