MODFLOW-USGS / modelviewer-mf6

Model Viewer for MODFLOW 6
https://modelviewer-mf6.readthedocs.io/
Other
7 stars 2 forks source link

Toolbox->Grid (Dialog--Lines tab) is wrong when grid is DISV (ex-gwf-disvmesh.mvmf6) #77

Open scharlton2 opened 1 year ago

scharlton2 commented 1 year ago

MFC version

image

Note that if you press the down button of the layer input (Lines tab) while the subgrid is activated it gets in a bad state -> displays -1 and can't be changed.

Qt version

image

Note that all the activate checkboxes are enabled on the Qt version

Also note that if the down button is pressed on the layer input it asserts (This occurs after the subgrid has been activated/deactivated).

It seems that the Qt dialog needs quite a bit of work for DISV grids

scharlton2 commented 1 year ago

Call Stack

gridDialog->applySubgrid doc->applySubgrid manager->SetScalarSubgridExtent m_ExtractCellsForSubgrid->SetCellList
manager->ScalarSubgridOn

doc->subgridOff

Does bounding box change as subgrid changes?

DIS6 yes DISV DISU

Do the grid lines change as the subgrid changes? DIS6 yes -- if it gets smaller DISV DISU

Does the origin move when the subgrid changes? DIS6 yes DISV DISU

Can the grid lines extend beyond the bounding box? DIS6 yes DISV DISU

Are model features subsetted?

Is the overlay subsetted?

When does (m_GridDisplayMode == MV_GRID_INTERPOLATE)

langevin-usgs commented 1 year ago

Hey @scharlton2, I'm not sure this is relevant, but Paul Hsieh implemented two types of representations for cell tops and bottoms. He had a shortcut key that allowed you to toggle between the representations. In one representation, the top elevation for each cell is shown as flat. In the other representation, cell tops and bottoms are interpolated to cell vertices. I think he then divided the cell top/bottom surface into triangles, which were then rendered. Just thought I'd mention it.

scharlton2 commented 1 year ago

Thanks @langevin-usgs, I wasn't aware of that. Do you know if he did that for all grids or just for DISV?