MODFLOW-USGS / mt3d-usgs

MT3D-USGS Repository
24 stars 12 forks source link

Use Travis CI to check for compilation warnings #48

Closed mwtoews closed 5 years ago

mwtoews commented 5 years ago

This PR allows Travis CI to compile and perform specific checks on the consistency of code, and ideally guard against introducing "bad code". This is done by passing FFLAGS to pymake, specifically -Werror which treats all warnings as errors, and fails the Travis CI with a log of compilation steps and errors, which is handy to see.

So far, I've added a few specific warnings flags from previous commits for tabs. And added to this PR is -Wcharacter-truncation, as there was a minor discrepancy between the data types.

When potential issues are resolved in the code for each warning type (docs here), then that flag can be added to fflags in autotest/config.py for testing on Travis CI.