The "gold standard" of warnings is to turn most of them on with -Wall (or -warn all for Intel). While this PR doesn't exactly do this, it does add most of them... and then turns off other warnings that may require more attention later (if any) using -Wno-...
Some manual work with gfortran -O2 -Wmaybe-uninitialized was done to try and resolve some potential uninitialized values for mt3dms and mt3d-usgs. Note that none of these are confirmed as bugs. However, not all of these warnings were resolved due to possible false positive GCC bugs (maybe), so -Wno-maybe-uninitialized is used to disable this warning for now. Also, this flag didn't help discover #46 so there are possibly other variables lurking that would require other tools (e.g. Intel or Valgrind) to identify.
The "gold standard" of warnings is to turn most of them on with
-Wall(or-warn allfor Intel). While this PR doesn't exactly do this, it does add most of them... and then turns off other warnings that may require more attention later (if any) using-Wno-...Also,
fflagsnow configured for breaking change from https://github.com/modflowpy/pymake/pull/28Some manual work with
gfortran -O2 -Wmaybe-uninitializedwas done to try and resolve some potential uninitialized values for mt3dms and mt3d-usgs. Note that none of these are confirmed as bugs. However, not all of these warnings were resolved due to possible false positive GCC bugs (maybe), so-Wno-maybe-uninitializedis used to disable this warning for now. Also, this flag didn't help discover #46 so there are possibly other variables lurking that would require other tools (e.g. Intel or Valgrind) to identify.