MODFLOW-USGS / mt3d-usgs

MT3D-USGS Repository
23 stars 12 forks source link

MT3D-USGS version is missing from LIST output file #80

Open mwtoews opened 4 years ago

mwtoews commented 4 years ago

The LIST file does not contain the version of MT3D-USGS. It shows versions of various packages (e.g. "BTN1 -- BASIC TRANSPORT PACKAGE, VERSION 1, MAY 2016"), but not "[Ver 1.1.0]", which is the most important detail.

This information is only shown thru stdout, which most users don't capture:

 MT3D-USGS - Modular 3D Multi-Species Transport Model [Ver 1.1.0]   
 and based on MT3DMS. MT3D-USGS developed in cooperation by 
 S.S. Papadopulos & Associates and the U.S. Geological Survey

see mt3d-usgs.f line 111. The list file contains similar information in a "program title" (line 160 of Fortran source), formatted and worded differently, but without version information:

                              +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
                              +                                                                     +
                              +                              MT3D-USGS                              +
                              +             A Modular 3D Multi-Species Transport Model              +
                              +    For Simulation of Advection, Dispersion and Chemical Reactions   +
                              +                of Contaminants in Groundwater Systems               +
                              +                                                                     +
                              +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++

(it seems this program title was formatted for a particular wide printer).

Some suggestions to choose from:

  1. Add version to the existing program title, or
  2. Append version info below the existing program title, or
  3. Remove the program title (since printers are now not used for this purpose), writing a simpler output identical to the stdout from line 111, but written to the list file.

I can send a PR based on the preferred option, unless anyone else wants to fix this up.

emorway-usgs commented 4 years ago

@mwtoews A PR sounds terrific, thanks for helping out with that.