MOIMOB / drinkable

Drinkable is an app which help you find cocktails that you could make today with ingredients from home
MIT License
127 stars 28 forks source link

TheCocktailDB integration #353

Closed SecularSteve closed 5 months ago

SecularSteve commented 1 year ago

https://www.thecocktaildb.com/

Another open source solution for cocktails that happens to have a lot more drinks listed.

Two ways this can go about:

-Add it all manually -Integrate the Database into the App itself

Of course, I'm making this suggestion with the intent that you're at least partially aware of it. It would be interesting to see their clunky site in a more consumable fashion. There's thousands of attempts on GitHub too with apps and web clients, but none of them seem as easy or efficient to use as your app.

But that's just my suggestion. Depending on the answer, I can try making a list/sheet of all the missing Cocktails currently present on the database.

anton-gustafsson commented 1 year ago

Hi! Thank you for opening this issue

I'm familiar with TheCocktailDB, a lot of cocktails used in Drinkable is import from there. However I did a lot of manual work to 'clean up' the data from the API so I don't really see a smooth way of integrating with the db itself. Here is some on top of my head improvements made in the app regarding data

Love to hear from you!

XayOn commented 1 year ago

If anyone is willing, this is data gotten from https://github.com/lauriharpf/thecocktaildb-downloader and pre-parsed (just a bit) to:

But alas, it's a start, and reduces a bit the need for manual labor.

drinkable.json.txt

github-actions[bot] commented 5 months ago

Stale issue message