MONEI / Shopify-api-node

Node Shopify connector sponsored by MONEI
https://monei.com/shopify-payment-gateway/
MIT License
952 stars 280 forks source link

Implement DELETE /admin/marketing_events/#{marketing_event_id}.json #179

Closed chris-klickly closed 6 years ago

chris-klickly commented 6 years ago

I see we're missing this. Any plans to implement it?

lpinca commented 6 years ago

It's already available, see https://github.com/MONEI/Shopify-api-node/blob/31c99628dec72901e37a1cc8daafd15a3b821af9/test/marketing-event.test.js#L82-L89

chris-klickly commented 6 years ago

That’s marketing events.

I mean more like marketingEvent.engagements.delete()

On Wed, Apr 11, 2018 at 10:29 PM Luigi Pinca notifications@github.com wrote:

It's already available, see https://github.com/MONEI/Shopify-api-node/blob/31c99628dec72901e37a1cc8daafd15a3b821af9/test/marketing-event.test.js#L82-L89

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/MONEI/Shopify-api-node/issues/179#issuecomment-380682750, or mute the thread https://github.com/notifications/unsubscribe-auth/AkDxD_xZEnFQXgfX3SGyPvnpv7NVKBQMks5tnuYygaJpZM4TQyIB .

lpinca commented 6 years ago

It seems there is no documentation for this? https://help.shopify.com/api/reference/marketing_event

lpinca commented 6 years ago

Maybe you can do this with:

shopify.marketingEvent.engagements(id, []);

but I'm not sure.

chris-klickly commented 6 years ago

Oh you’re right. Nevermind thank you!

On Wed, Apr 11, 2018 at 10:46 PM Luigi Pinca notifications@github.com wrote:

It seems there is no documentation for this? https://help.shopify.com/api/reference/marketing_event

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/MONEI/Shopify-api-node/issues/179#issuecomment-380685756, or mute the thread https://github.com/notifications/unsubscribe-auth/AkDxDz5nEgBmSyoC0Q9wVf9VRsuUIkK0ks5tnuo1gaJpZM4TQyIB .

lpinca commented 6 years ago

Closing, let me know if it should stay open instead.