search

MONEI / Shopify-api-node

Node Shopify connector sponsored by MONEI
https://monei.com/shopify-payment-gateway/
MIT License
952 stars 280 forks source link

IInventoryItem interface is missing properties. #425

Closed MBogdan18 closed 4 years ago

MBogdan18 commented 4 years ago

According to both the Shopify API documentation and the screenshot below, when I retrieve an inventory item I should be prompted with the cost field. However, I can not access it because the property doesn't exist on the interface itself and TypeScript returns an error as a result.

GET /admin/api/2020-10/inventory_items/808950810.json docs: https://shopify.dev/docs/admin-api/rest/reference/inventory/inventoryitem#show-2020-10

Mentioning that I do have the latest version installed (3.5.1 as of the date this was written).

Screenshot_1

Screenshot_2

lpinca commented 4 years ago

Feel free to open a PR to fix the type definitions. It looks like country_harmonized_system_codes and province_code_of_origin are also missing and country_code_of_origin, and harmonized_system_code can be null.