search

MONEI / Shopify-api-node

Node Shopify connector sponsored by MONEI
https://monei.com/shopify-payment-gateway/
MIT License
946 stars 277 forks source link

Iterator feature #457

Closed chewax closed 3 years ago

chewax commented 3 years ago

Added new iterator feature to the base mixin to be able to list and paginate at once. It will iterate though all elements that match param and handling pagination.

coveralls commented 3 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling 9106925ddf061c8e6064e5daac5f8f77a713cbb5 on chewax:master into 608ff96051ca5b0b2682e622667fb6fa7231d5a6 on MONEI:master.

lpinca commented 3 years ago

Thanks but I'm not a fan of this. I don't like to have an iterate action when the ability to paginate results is already available.

The current feature requires only a few more line of code and users that want to use for await...of can extend the classes like you did here.

chewax commented 3 years ago

Ok no worries. Have a great day.

On Tue, Feb 2, 2021, 03:22 Luigi Pinca notifications@github.com wrote:

Thanks but I'm not a fan of this. I don't like to have an iterate action when the ability to paginate results is already available https://github.com/MONEI/Shopify-api-node#pagination.

The current feature requires only a few more line of code and users that want to use for await...of can extend the classes like you did here.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/MONEI/Shopify-api-node/pull/457#issuecomment-771396091, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABWV263GPLETBIIEBRED6BLS46KZXANCNFSM4W53OOCQ .

lpinca commented 3 years ago

I'm closing this. Thank you anyway.