search

MONEI / Shopify-api-node

Node Shopify connector sponsored by MONEI
https://monei.com/shopify-payment-gateway/
MIT License
946 stars 278 forks source link

Removing discount allocation method "one" #468

Closed LukasGirsch closed 3 years ago

LukasGirsch commented 3 years ago

With the change to 2020-07 the discountAllocation method does not support 'one' anymore but 'each' and 'accros'

The interface does seem to still be specifying the option 'one'.

https://github.com/MONEI/Shopify-api-node/blob/88d5e04a6446523a358d7f2db8017bd7e20df2e3/index.d.ts#L1360

Also I'am getting the error meassge in my shopify admin panel that I'am still using this option in one of my api calls but I'am not using it. Is there any chance that this is correlated? I just checked and I'am not using any calls inside my app bellow 2020-10.

image

This is the changelog: changelog

lpinca commented 3 years ago

Is there any chance that this is correlated?

No, I see no correlation. Type definitions do not change what is sent in the HTTP request body.

LukasGirsch commented 3 years ago

@lpinca That's what I assumed. Thank you.

umang135 commented 3 years ago

Any solution to solve this?

lpinca commented 3 years ago

If you have already migrated just ignore the warning. I'm closing this as the deadline in the issue description expired.