MONEI / Shopify-api-node

Node Shopify connector sponsored by MONEI
https://monei.com/shopify-payment-gateway/
MIT License
946 stars 278 forks source link

Fix type definitions #483

Closed gabrielvincent closed 3 years ago

gabrielvincent commented 3 years ago

This pull request fixes the following type definitions:

~province: string~ -> province: string | null ~province_code: string~ -> province_code: string | null ~latitude: string~ -> latitude: number | null ~longitude string~ -> longitude: number | null

Example of actual data sent by the Shopify API:

types province can be null. latitude/longitude are number

types2 latitude/longitude can be null

coveralls commented 3 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling 2df1642e8a0ee96629f0bd0ccc73b90923754b55 on gabrielvincent:fix/types into b1e7a9e38120890c47acae21bac8dfd19d9e6cd5 on MONEI:master.

lpinca commented 3 years ago

Thank you.