search

MONEI / Shopify-api-node

Node Shopify connector sponsored by MONEI
https://monei.com/shopify-payment-gateway/
MIT License
946 stars 278 forks source link

Add params for productListing typings #485

Closed dcrdev closed 3 years ago

dcrdev commented 3 years ago

The productListing count method typings were missing the ability to pass in params.

The productListing count supports a number of params: https://shopify.dev/docs/admin-api/rest/reference/products/product#count-2021-04

coveralls commented 3 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling d9f3837d74324de264081e6530b1c3e826ffba56 on slingshotlabs:master into a73906962561733d5eb845f54ed69f07682c9f94 on MONEI:master.

lpinca commented 3 years ago

Thank you.

lpinca commented 3 years ago

Btw this is not documented. The documentation you linked is for the Product resource not ProductListing. See https://shopify.dev/docs/admin-api/rest/reference/sales-channels/productlisting#count-2021-04.

lpinca commented 3 years ago

Do you know what are the accepted parameters so that I can write a test for this?