MONEI / Shopify-api-node

Node Shopify connector sponsored by MONEI
https://monei.com/shopify-payment-gateway/
MIT License
945 stars 278 forks source link

The force_ssl field has been removed from the API of the REST Shop administrator interface #523

Closed tdryjard closed 2 years ago

tdryjard commented 2 years ago

We must remove "force_ssl" from shop interface (file: index.d.ts => line: 2736)

yongyi520 commented 2 years ago

@tdryjard I got this warning on shopify when calling app/uninstall webhook

Is there a way for us to turn it off with new versions? like "2022-01"? My current version is already "2021-07"

Screen Shot 2022-01-12 at 16 29 24
tdryjard commented 2 years ago

This is what this issue is about. If you want to solve the problem yourself without waiting for the update, you have to change the code of shopify-api-node with the above indications and then extract the library folder from node_modules. (I advise you to wait for the next update of the library and to update it on your project)

yongyi520 commented 2 years ago

@tdryjard Thank you for the advice, I will wait for the update!

lpinca commented 2 years ago

The force_ssl field is optional. There is no need to remove it. Also, removing it does not change anything. TypeScript type definitions do not influence what is sent and received.

tdryjard commented 2 years ago

@lpinca so why is shopify giving us this warning? force_ssl would be sent somewhere else?

lpinca commented 2 years ago

so why is shopify giving us this warning? force_ssl would be sent somewhere else?

I don't know, and no, it is not sent by the library unless you are explicitly sending it somewhere, which I think it is not the case. In the documentation the field is returned by Shopify itself.

You can ignore the warning.

tdryjard commented 2 years ago

Alright, thanks for your work. Have a good day

yongyi520 commented 2 years ago

I had the same issue getting the force_ssl error on app/uninstall. I searched force_ssl in my entire code base and nothing showed up @lpinca @tdryjard

Still continue to have this error for new customers even when i updated with latest 2022-01 version

lpinca commented 2 years ago

I'm closing this due to inactivity.