search

MONEI / Shopify-api-node

Node Shopify connector sponsored by MONEI
https://monei.com/shopify-payment-gateway/
MIT License
945 stars 278 forks source link

Private apps (and Basic auth) are deprecated as of January 2022 #529

Closed Pwuts closed 2 years ago

Pwuts commented 2 years ago

According to the docs, private apps have been deprecated, and new apps can use the access token obtained when creating a custom app in the Shopify admin.

Could the docs of this library be updated accordingly? I'm not sure if it still works for existing apps, but if not the Basic auth can also be removed from the client.

lpinca commented 2 years ago

We can remove the documentation for the apiKey and password options but removing the functionality does not make much sense in my opinion. It is an unnecessary breaking change.

Pwuts commented 2 years ago

Well if Shopify has removed support on their side it also wouldn't make sense to keep the (then useless) code. But as I said, I don't know if they have really disabled it or just disabled creating new private apps.

lpinca commented 2 years ago

I just tested it. The apiKey and password options still work for existing apps.