Closed Pwuts closed 2 years ago
We can remove the documentation for the apiKey
and password
options but removing the functionality does not make much sense in my opinion. It is an unnecessary breaking change.
Well if Shopify has removed support on their side it also wouldn't make sense to keep the (then useless) code. But as I said, I don't know if they have really disabled it or just disabled creating new private apps.
I just tested it. The apiKey
and password
options still work for existing apps.
According to the docs, private apps have been deprecated, and new apps can use the access token obtained when creating a custom app in the Shopify admin.
Could the docs of this library be updated accordingly? I'm not sure if it still works for existing apps, but if not the Basic auth can also be removed from the client.