MONEI / Shopify-api-node

Node Shopify connector sponsored by MONEI
https://monei.com/shopify-payment-gateway/
MIT License
945 stars 278 forks source link

wrong behaviour of discount lookup #553

Closed pociej closed 1 year ago

pociej commented 1 year ago

When one use api client to check discount code validity and code to check is invalid it throws instead of returning what api actual returns. So

await api.discountCode.lookup({
  code: "invalid_code",
});

and it throws 404 while direct call to rest api gives :

{"errors":"Not Found"}
pociej commented 1 year ago

My bad. Its shopify who returns 404, it doesn't make sense but it is not fault of package of course.