[ts] Fix IOrderDiscountCode.amount type

MONEI / Shopify-api-node

Node Shopify connector sponsored by MONEI

https://monei.com/shopify-payment-gateway/

MIT License

940 stars 279 forks source link

[ts] Fix IOrderDiscountCode.amount type #565

Closed summersk closed 1 year ago

summersk commented 1 year ago

Changes amount from number to string per API docs (sample response, types undocumented in resource listing).

155    "discount_codes": [
156      {
157        "code": "SPRING30",
158        "amount": "30.00",
159        "type": "fixed_amount"
160      }
161    ],
Order resource example response (https://shopify.dev/api/admin-rest/2022-04/resources/order#resource-object)

FYI line_items.discount_allocations (ILineItemDiscountAllocation) has amount: string already.

coveralls commented 1 year ago

Coverage: 100.0%. Remained the same when pulling b3c1f6aefec185b8bf974535a8b784d5ee9181ac on summersk:patch-2 into 01f0e7bcbe82426664b220bfd9e068cd2b4d09cf on MONEI:master.

lpinca commented 1 year ago

Thank you.