search

MONEI / Shopify-api-node

Node Shopify connector sponsored by MONEI
https://monei.com/shopify-payment-gateway/
MIT License
940 stars 279 forks source link

Fix #566 and introduce light types tests #568

Closed airhorns closed 1 year ago

airhorns commented 1 year ago

This fixes a type error introduced in https://github.com/MONEI/Shopify-api-node/commit/eeda19880b634d5080e3ab2cc5b77513276c8dbe and reported in https://github.com/MONEI/Shopify-api-node/issues/566 . I made this mistake by copying code suitable for got 12 into a codebase using got 11 -- my apologies! To avoid breakages like this, I think it'd be good to have a lightweight typescript test suite that verifies the types file works as expected. tsd is a great tool for this so I added it here as well.

coveralls commented 1 year ago

Coverage Status

Coverage: 100.0%. Remained the same when pulling c51fc2f926b6059573bf58421a5eb833a3707ab5 on gadget-inc:tsd into cfafdf1ce006c5e9c85f447a0dc9f85ce2d4d42e on MONEI:master.

lpinca commented 1 year ago

Landed in cfafdf1ce006c5e9...a329b5ecf890be01.

lpinca commented 1 year ago

Thank you.