MONEI / Shopify-api-node

Node Shopify connector sponsored by MONEI
https://monei.com/shopify-payment-gateway/
MIT License
940 stars 278 forks source link

Fix issue with metafields #607

Closed aurelien-robineau closed 1 year ago

aurelien-robineau commented 1 year ago

Metafields are child resources, so must use the base-child mixin.

For example, the metafields list function only returns the Shop metafields, regardless of the owner_resource and owner_id that we provide.

lpinca commented 1 year ago

This does not work. If we do this we have to create a metafield resource for each parent resource. ArticleMetafield, BlogMetafield, etc. Metafield used to be a top-level resource and AFAIK it still works as top-level resource.

lpinca commented 1 year ago

I'm closing this as per https://github.com/MONEI/Shopify-api-node/issues/606.