search

MONEI / Shopify-api-node

Node Shopify connector sponsored by MONEI
https://monei.com/shopify-payment-gateway/
MIT License
947 stars 278 forks source link

Fixed type of ICustomer.multipass_identifier #654

Closed natewaddoups closed 3 months ago

natewaddoups commented 3 months ago

I suspect that "multipass_identifier: null" was never the intent...

natewaddoups commented 3 months ago

There's a bigger problem here - the createCustomer mutation expects an object with camelCased properties, but the shopify-api-node library requires an object with snake_cased properties.

Reopening the PR because the createCustomer mutation works with both snake_case and camelCase, so the existing property names are just fine.

coveralls commented 3 months ago

Coverage Status

coverage: 100.0%. remained the same when pulling 2dec9b89c6e2af6662beccae8ab8d39d639dd3ec on natewaddoups:master into fd6d034440fd08fd9a97765c37152ecc5a6e7d5a on MONEI:master.

lpinca commented 3 months ago

Thank you.