search

MORE-Platform / more-app-multiplatform

The mobile application for the MORE platform.
https://more-health.at
Other
6 stars 1 forks source link

Inconsistency in Time Range Display for relative observations #215

Closed alireza-dhp closed 5 months ago

alireza-dhp commented 5 months ago

The observation is set for the first day from 7 a.m. to 11 a.m., but when I logged in during the specified time range (before 11 a.m.), it displays observation for the next day instead! This issue occurs on both iPhone and Android! Please check the following video: https://www.loom.com/share/e2f4eba0693346459911dd87c82d7957?sid=175822f0-3f21-4aa5-b22a-d802e7d0c62b

tkurz commented 5 months ago

This is intended I think. If an observation happens on the first day an it is already running on the time of joining, the study starts on the next day. If this behavior should be different, we have to change it in the algorithm (somewhere here https://github.com/MORE-Platform/more-data-gateway/blob/redlink-staging/src/main/java/io/redlink/more/data/schedule/SchedulerUtils.java#L45)

alireza-dhp commented 5 months ago

But as soon as I changed the end time, the current day is considerd as a first day. Is it possible that this is linked to keeping time in UTC and displaying it in Central European Time (CET)? Please check the following video: https://www.loom.com/share/4d24bbf710df4e6d8c8d20a3f0ac32dc?sid=c73af821-61bf-48fc-8c43-0d8ee8982a40

alireza-dhp commented 5 months ago

This issue is fixed by this https://github.com/MORE-Platform/more-data-gateway/pull/110 PR on data-gateway repo