search

MOTDgd-Ltd / sourcemod-plugin

MOTDgd SourceMod Plugin
10 stars 6 forks source link

HTTPRequestHandle Invalid - Not yet sent or Invalid Buffer Size #6

Open ProfessorFartsalot opened 5 years ago

ProfessorFartsalot commented 5 years ago

My server's running Sourcemod 1.9.2.0 -6281 with Metamod 1.10.7-dev and I'm unable to see any ads.

Using SteamTools, I get this error in console from motdgd:

L 08/07/2019 - 15:39:59: [SM] Exception reported: HTTPRequestHandle invalid, not yet sent or invalid buffer size L 08/07/2019 - 15:39:59: [SM] Blaming: motdgd_adverts.smx L 08/07/2019 - 15:39:59: [SM] Call stack trace: L 08/07/2019 - 15:39:59: [SM] [0] Steam_GetHTTPResponseBodyData L 08/07/2019 - 15:39:59: [SM] [1] Line 501, include/EasyHTTP.inc::EasyHTTP_SteamToolsComplete

Any help?

Glubbable commented 5 years ago

SteamTools is obsolete and no longer supported. I recommend switching to SteamWorks as that extension is still supported.

https://github.com/KyleSanderson/SteamWorks

ProfessorFartsalot commented 5 years ago

SteamWorks still results in issues it seems. However, I've contacted support and they've informed me this is because ad availability is currently limited.

Glubbable commented 5 years ago

This error prevents the plugin from even sending a HTTP Request, it has nothing to do with ad availability on their end.

ProfessorFartsalot commented 5 years ago

I'm running SteamWorks and it's still giving me the same issue of "No ad was found". I've since removed steamtools after discovering a similar issue on this very github repo and their solution was to move to steamworks. With SteamWorks, the "No video ad was found!" message appears in game still.

Glubbable commented 5 years ago

This error has nothing to do with ad availability though as I have already explained.

ProfessorFartsalot commented 5 years ago

I'm aware of that, hence why I switched to SteamWorks literally an hour after posting this. That issue no longer is present. The issue is that I'm getting the no video ad message. Either way, it seems more video ads are available, though it takes clients 15 seconds to find an ad.

Glubbable commented 5 years ago

From what I know, Ad Availability varies from day to day and more often than not is that most countries do not have suffient ad fulfillment in order to constantly supply all of your traffic with advertisements. As a result of this, you'll often get the error that an ad was never found for you.

However, advertisements are no longer a sustainable income for server hosting due to the long stemmed abuse caused by rogue hosters. Casual in TF2 came to be because of people setting up server farms on cheap VDSs in order to overwhelm Quickplay results. These servers would not only trick Quickplay (attracting Valve's ire) but also would attempt to abuse services like MOTDgd to rapid fire ads to players that had been sent into those servers.

Knowing this, MOTDgd fill rates are probably low due to being lower priority within their larger networked circles due to the period of time where Valve took the in-built webhelper and broke it over it's back to stop the abuse of the MOTD. However, I do not work in advertisement media so I have no idea how any of the backend works outside of publically shared information.

Currently as it stands, community hosting is dying, it is hard to sustain servers without the support of alternative incomes. This kind of problem could've been avoided if the abuse from rogue hosters was noticed early and stopped in their tracks. But it sadly lasted long enough to attract Valve's ire.

The current TF Team has expressed interest in reviving the community server space, however, they are most likely hesitant over it because of what has happened in the past. The community at large has proven to Valve that it cannot be trusted.

I hope this is helpful information to you. But keep in mind that I do not work for MOTDgd, I just commited code changes in the past as I use this plugin myself.