search

MOV-AI / movai-flow

MOV.AI Flow™ - The IDE that brings visualization and structure to ROS
Other
122 stars 15 forks source link

Stop exposing ros-master port and better health check #148

Closed MithunKinarullathil closed 2 years ago

MithunKinarullathil commented 2 years ago

@xsoulp FYI. This should solve a bit of the issue you were mentioning. @diasdm This should be enough for the sonarqube test?

[^note]: Put an x into the [ ] to show you have filled the information. The template comes from https://github.com/MOV-AI/.github/blob/master/.github/pull_request_template.md You can override it by creating .github/pull_request_template.md in your own repository

guide-bot[bot] commented 2 years ago

Thanks for opening this Pull Request! We need you to:

  1. Complete the activities.

    Action: Complete Link to relevant issues in GitHub or Jira Action: Complete Link to relevant pull requests, esp. upstream and downstream changes Action: Complete Ensure you have provided tests - that demonstrates feature works or fixes the issue

    If an activity is not applicable, use '\~activity description\~' to mark it not applicable.

MithunKinarullathil commented 2 years ago

This PR is just to close up a wound that is restricting the users without additional advantage. We have another good way to expose the ROS topics using the movai-cheatsheet, which has been tested thoroughly in the EE. It is better than exposing the full network to the host (which can have unintended consequences). So to summarize what this PR archives.

AlexFernandes-MOVAI commented 2 years ago

This PR is just to close up a wound that is restricting the users without additional advantage. We have another good way to expose the ROS topics using the movai-cheatsheet, which has been tested thoroughly in the EE. It is better than exposing the full network to the host (which can have unintended consequences). So to summarize what this PR archives.

  • User is able to run their own ROS launches and ROS things in their host independently with movi-flow running beside it. (currently, this is not possible if movai-flow is running, which is restricting function without providing additional value)
  • For the short term we will document the steps from the cheat sheet, and how to expose topics manually to the community
  • For the long term, once the cheatsheet tools are exposed, they will be able to do this easily using the cli.

OK, I got it. I will just complete that for the long term, I would recommend not to have any CLI at all ;)

MithunKinarullathil commented 2 years ago

This PR is just to close up a wound that is restricting the users without additional advantage. We have another good way to expose the ROS topics using the movai-cheatsheet, which has been tested thoroughly in the EE. It is better than exposing the full network to the host (which can have unintended consequences). So to summarize what this PR archives.

  • User is able to run their own ROS launches and ROS things in their host independently with movi-flow running beside it. (currently, this is not possible if movai-flow is running, which is restricting function without providing additional value)
  • For the short term we will document the steps from the cheat sheet, and how to expose topics manually to the community
  • For the long term, once the cheatsheet tools are exposed, they will be able to do this easily using the cli.

OK, I got it. I will just complete that for the long term, I would recommend not to have any CLI at all ;)

Haha. I have to disagree from a ros developer perspective. It's much easier for me to develop with a cli even if there is a good UI tool. It saves time ;)

sonarcloud[bot] commented 2 years ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication