Define networks in both docker-compose, but reference from .env file.

MOV-AI / movai-flow

MOV.AI Flow™ - The IDE that brings visualization and structure to ROS

Other

121 stars 15 forks source link

Define networks in both docker-compose, but reference from .env file. #185

Closed MithunKinarullathil closed 1 year ago

MithunKinarullathil commented 2 years ago

https://movai.atlassian.net/browse/DP-928
[x] Make sure you are opening from a topic/feature/bugfix branch
[x] Ensure that the PR title represents the desired changes
[x] Ensure that the PR description detail the desired changes
[x] Link to relevant issues in GitHub or Jira
[ ] ~~Link to relevant pull requests, esp. upstream and downstream changes~~
[ ] ~~Ensure you have provided tests - that demonstrates feature works or fixes the issue~~

[^note]: Put an x into the [ ] to show you have filled the information. The template comes from https://github.com/MOV-AI/.github/blob/master/.github/pull_request_template.md You can override it by creating .github/pull_request_template.md in your own repository

github-actions[bot] commented 2 years ago

`yamllint` Failed

Show Output

``` ::group::docker-compose.yml ::error file=docker-compose.yml,line=316,col=1::316:1 [empty-lines] too many blank lines (1 > 0) ::endgroup:: ```

Workflow: PR Checks, Action: __karancode_yamllint-github-action, Lint: docker-compose.yml docker-compose-nvidia.yml docker-compose-host.yml docker-compose-nvidia-host.yml

MithunKinarullathil commented 2 years ago

@AlexDesfa I'm not sure if this is the right fix but it seems to solve the issue.