need a ros_distro parameter

MOV-AI / movai_ign_plugins

Repository for holding the system and gui plugins for the ignition simulator

Other

0 stars 0 forks source link

Closed AlexFernandes-MOVAI closed 2 years ago

AlexFernandes-MOVAI commented 2 years ago

[x] Make sure you are opening from a topic/feature/bugfix branch
[x] Ensure that the PR title represents the desired changes
[x] Ensure that the PR description detail the desired changes
[ ] Link to relevant issues in GitHub or Jira
[ ] Link to relevant pull requests, esp. upstream and downstream changes
[ ] Ensure you have provided tests - that demonstrates feature works or fixes the issue

[^note]: Put an x into the [ ] to show you have filled the information. The template comes from https://github.com/MOV-AI/.github/blob/master/.github/pull_request_template.md You can override it by creating .github/pull_request_template.md in your own repository

guide-bot[bot] commented 2 years ago

Thanks for opening this Pull Request! We need you to:

Fill out the description.

Action: Edit description and replace <!- ... --> with actual values.
Complete the activities.

Action: Complete Link to relevant issues in GitHub or Jira Action: Complete Link to relevant pull requests, esp. upstream and downstream changes Action: Complete Ensure you have provided tests - that demonstrates feature works or fixes the issue

If an activity is not applicable, use '\~activity description\~' to mark it not applicable.

MithunKinarullathil commented 2 years ago

These packages are independent of ROS. Adding this key shouldn't affect anything on the released package right?

AlexFernandes-MOVAI commented 2 years ago

These packages are independent of ROS. Adding this key shouldn't affect anything on the released package right?

ok, good point. I will double check the impacts