search

MOZI-AI / annotation-scheme

Human Gene annotation service backend
GNU General Public License v3.0
3 stars 4 forks source link

Remove unnecessary call/cc #101

Closed Habush closed 4 years ago

Habush commented 4 years ago

Remove the call/cc which are unnecessary and according to @linas have impact on performance. This is discussed in #98

linas commented 4 years ago

Thank you; this seems to work. For me "to work" means "not to crash", and I can now get performance trace results as described in #98 I cannot tell if this is generating correct results or not.

tanksha commented 4 years ago

@Habush the GO cross annotation from biogrid is not correct. Check running the biogrid-annotation with GO namespace and the interaction type being "Protein". it doesn't have any GO result. Please include that.

Update: This issue is not dueto the above code change and will be solved with issue #114.

rekado commented 4 years ago

Is there a test for this property of the parser result? Having more extensive tests would allow for more confident refactoring of the parser code.

Habush commented 4 years ago

@rekado, @tanksha's issue isn't related to the parser specifically. It is related to issue #114. Hedra, please delete or edit the above comment