search

MOZI-AI / annotation-scheme

Human Gene annotation service backend
GNU General Public License v3.0
3 stars 4 forks source link

Simplify parser #112

Closed rekado closed 4 years ago

rekado commented 4 years ago

This is a very conservative set of changes to the parser module intended to simplify and clarify the intent of the code.

With these changes the tests still pass, but the parser tests are too simple to catch any serious problems.

I thought it would make sense to simplify the code before attempting to rewrite it in terms of read.

Habush commented 4 years ago

Per PR #101 I have removed the call/cc continuations but your code still contains them as it is based on a version before the PR is merged. Can you please base your changes on the latest code? I have also added two test methods for the parser. See #115

rekado commented 4 years ago

I've rebased the commits (and fixed a bug that I introduced in the earlier versions). The tests all pass.

rekado commented 4 years ago

I'm curious if anything is blocking the merge. The tests pass and this is the foundation of further simplifications to the parser code. If there's something wrong with the results please let me know so that the tests can be adapted.

Habush commented 4 years ago

@rekado I will merge the PR after I test it locally today. Sorry for not responding sooner :)