MOZI-AI / annotation-scheme

Human Gene annotation service backend
GNU General Public License v3.0
3 stars 4 forks source link

Simplify parser #121

Closed rekado closed 4 years ago

rekado commented 4 years ago

This is the next set of changes to simplify the parser. The tests still pass, but the changes are less conservative.

Instead of using a LALR parser we simply recurse over the expression and build up the graph. This allows us to get rid of nyacc.

There's still more work to be done that can build on this set of changes:

and finally:

rekado commented 4 years ago

With the last commit the fork of Guile JSON is no longer needed. Yay!

Habush commented 4 years ago

@rekado Thank you!

rekado commented 4 years ago

@leungmanhin Guile JSON 3.0 changed the internal representation of values. It uses vectors instead of lists and no longer uses hash maps IIRC.

Since the test coverage is very limited I decided to keep the changes conservative. Upgrading to Guile JSON 3.0 should come with additions to the test suite to make sure that the JSON values the code processes have the expected type.

leungmanhin commented 4 years ago

Good to know, thank you @rekado