search

MOZI-AI / annotation-scheme

Human Gene annotation service backend
GNU General Public License v3.0
3 stars 4 forks source link

Fix the issue of parser not handling a list of ListLinks #172

Closed Habush closed 4 years ago

Habush commented 4 years ago

This fixes #162. Note this PR is different from #171 as it still does string conversion. #171 still needs more work so this one is quick-fix till the other PR is merged.

tanksha commented 4 years ago

@Habush with this PR I am getting error at annotate-genes function, unable to convert the json to string, did you check?

Habush commented 4 years ago

Ah, yes. I forgot to mention this PR depends on the fixes done on https://github.com/aconchillo/guile-json/pull/54. Until the maintainer of the guile-json repo merges the PR, please use the forked repo and checkout the json-string-fix branch.

linas commented 4 years ago

Well, this is sort-of dangerous; aconchillo might take a day or a week or months to apply the patch, or might reject it. In the meanwhile. the unit tests break... and I guess the system breaks too? Is there a way to work around this so that both forms work?

rekado commented 4 years ago

As I commented on the Guile JSON PR, I think this is the wrong approach. Why not pre-process your data to convert records to one of the many possible string representations?